Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsce should package closure without devDependencies #2114

Closed
heaths opened this issue Jan 19, 2016 · 1 comment
Closed

vsce should package closure without devDependencies #2114

heaths opened this issue Jan 19, 2016 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@heaths
Copy link
Member

heaths commented Jan 19, 2016

Using mainly the default generated files from generator-code, a significant number of devDependencies (mostly recursive) are pulled in - mainly because of Mocha. For development this is fine (I love Mocha). But why blindly package them all with vsce package? Perhaps create an output directory of everything vsce ls would find but node_modules, then run npm install --production and package that directory. Would certainly reduce the size of VSCode extensions. Mine - with only the addition of 1 small module (with no dependencies itself) is over 5MB.

@joaomoreno
Copy link
Member

Duplicate of microsoft/vscode-vsce#52

@joaomoreno joaomoreno added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants