Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky Scroll Shadow/Border Customization #157185

Closed
demipixel opened this issue Aug 5, 2022 · 12 comments · Fixed by #200239
Closed

Sticky Scroll Shadow/Border Customization #157185

demipixel opened this issue Aug 5, 2022 · 12 comments · Fixed by #200239
Assignees
Labels
editor-sticky-scroll feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded

Comments

@demipixel
Copy link

Especially in dark mode, it can be easy to miss that there's a shadow there (maybe I'm just blind).

Relavent section:

this.rootDomNode.style.boxShadow = `var(--vscode-scrollbar-shadow) 0 6px 6px -6px`; // '0px 0px 8px 2px #000000';

Would love if the box shadow and/or bottom-border was customizable in the theme.

@demipixel
Copy link
Author

demipixel commented Aug 6, 2022

I recently learned of editorStickyScroll.background which you can put in your theme, and I think it helps a lot, but I'll leave this ticket open since it would be a nice QoL and doesn't seem like it would be super difficult.

@Staindk
Copy link

Staindk commented Aug 8, 2022

For what it's worth I can see the shadow quite clearly (even in your screenshot).

You probably aren't blind 😅 - rather I think your monitor's gamma may be set a bit dark (or your monitor is bad at colour reproduction, or you work in weird lighting conditions, or or or).

If you're on windows you could run "Calibrate display color" and see if that helps. Even if it's just to test out my theory (mess around with the gamma slider to check things out, and then hit cancel). You may also be able to set gamma in your monitor's OSD.

I still think this is a worthwhile request though!

@jjspace
Copy link

jjspace commented Aug 8, 2022

You can already modify that theme value in your settings. It's using the scrollbar.shadow which also applies to the breadcrumbs, the explorer, and likely other locations the app. Might not be worth adding a specific shadow property for this feature and stick to relying on the same scroll shadow that's used everywhere depending on the demand?

{
  "workbench.colorCustomizations": {
    "scrollbar.shadow": "#ff0000"
  }
}

@alexdima alexdima added the feature-request Request for new features or functionality label Aug 8, 2022
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Aug 8, 2022
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@The-Compiler
Copy link

With Gruvbox Theme - Visual Studio Marketplace, I can't make out a shadow at all, on two different screens:

image

It looks like that theme defines a scrollbar.shadow which is the same color as editorWidget.background. I quite like the simplicity of it, but here it is confusing... Not sure if that could be considered a bug in the theme though.

I ended up configuring editorStickyScroll.background instead, which I prefer:

image

@trusktr
Copy link

trusktr commented Aug 13, 2022

My theme didn't have any shadow either. Good to know about the background option.

@dashed
Copy link

dashed commented Aug 18, 2022

For anyone else just as confused as I am on how to personalize this, you can edit settings.json with the following:

{
  // ...
  "editor.experimental.stickyScroll.enabled": true,
  "workbench.colorCustomizations": {
    "editorStickyScroll.background": "#181a1f",
    "editorStickyScrollHover.background": "#272930"
  }
}

@jibbers42
Copy link

Customizing the background color as described does make this feature more usable under my color theme, but I'd still appreciate the ability to make a harder border than I currently have.

@vilicvane
Copy link

I would prefer showing ... lines per level. I think that would be much more intuitive comparing to current shadow style, even if it takes larger spaces.

class Foo
    [...]
    hello
        world
        [...]
_________________________
        some other code

@aguscha333
Copy link

I am using the high contrast dark mode that comes with VSCode, one would expect that one to have a visible difference between the sticky scroll and the rest of the code. I fixed it in my editor with editorStickyScroll.background as many mentioned. It would be great if it was fixed for everyone since it is a theme that comes with the editor

@vscodenpa
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@aiday-mar aiday-mar modified the milestones: Backlog Candidates, On Deck Sep 28, 2022
@jrieken jrieken self-assigned this Oct 5, 2022
@jrieken jrieken modified the milestones: On Deck, Backlog Dec 8, 2022
@jrieken jrieken added the help wanted Issues identified as good community contribution opportunities label Dec 8, 2022
@crystalfp
Copy link

Thanks for sharing the trick! At the end the best result is by changing the background.

 "workbench.colorCustomizations": {
    "editorStickyScroll.background": "#000000",
    "editorStickyScrollHover.background": "#272930"
  }

Thanks again!
mario

@jrieken jrieken assigned aiday-mar and unassigned jrieken Dec 7, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Jan 23, 2024
@rzhao271 rzhao271 modified the milestones: Backlog, December / January 2024 Jan 23, 2024
@hediet hediet added the verified Verification succeeded label Jan 24, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-sticky-scroll feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.