Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sticky scroll] distinguish the sticky lines better #157732

Closed
trusktr opened this issue Aug 10, 2022 · 2 comments
Closed

[sticky scroll] distinguish the sticky lines better #157732

trusktr opened this issue Aug 10, 2022 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-sticky-scroll

Comments

@trusktr
Copy link

trusktr commented Aug 10, 2022

I love this new feature, I just started to try it and it seems useful.

I thought maybe sticky lines should have some sort of visual distinction. Right now, they look the same as other lines. When smooth scrolling (f.e. inertial scroll with animation) it is obvious. When performing actions that trigger single-frame scroll (no animation) we might not immediately realize lines at the top are not actually at that position.

What could be the solution? Maybe highlight the line number of the sticky line a little, or maybe the whole line. Or maybe a subtle underline below the last stick line.

@gjsjohnmurray
Copy link
Contributor

See #157185 (comment)

@alexdima
Copy link
Member

Let's continue discussion in #157185

@alexdima alexdima added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-sticky-scroll
Projects
None yet
Development

No branches or pull requests

4 participants