Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stick scroll blends into editor contents with high contrast theme #172570

Closed
mjbvz opened this issue Jan 26, 2023 · 2 comments · Fixed by #174461 or #174934
Closed

Stick scroll blends into editor contents with high contrast theme #172570

mjbvz opened this issue Jan 26, 2023 · 2 comments · Fixed by #174461 or #174934
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug editor-sticky-scroll insiders-released Patch has been released in VS Code Insiders verification-found Issue verification failed verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 26, 2023

Type: Bug

  1. Enable stick scroll
  2. Switch to high contrast
  3. Scroll down in a file

Bug
There is no contrast between the stick scroll content and the normal editor content:

Screenshot 2023-01-26 at 10 31 17 AM

Related #157185

VS Code version: Code - Insiders 1.75.0-insider (Universal) (07d6f5b, 2023-01-26T05:22:17.192Z)
OS version: Darwin x64 22.2.0
Modes:
Sandboxed: Yes

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Load (avg) 2, 2, 2
Memory (System) 32.00GB (0.02GB free)
Process Argv --crash-reporter-id 48781ca2-1705-4f64-9bab-325055aab55d
Screen Reader no
VM 0%
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug editor-sticky-scroll accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jan 27, 2023
@aiday-mar aiday-mar assigned aiday-mar and unassigned jrieken Feb 15, 2023
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Feb 16, 2023
@vscodenpa vscodenpa added this to the February 2023 milestone Feb 16, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 17, 2023
@aiday-mar
Copy link
Contributor

For verification:

  1. Enable sticky scroll, switch to high-contrast and scroll down the file.
  2. You should see a border on the bottom of the sticky scroll widget

@aiday-mar aiday-mar added the verification-needed Verification of issue is requested label Feb 20, 2023
@bpasero
Copy link
Member

bpasero commented Feb 21, 2023

I see it in dark theme but not light high contrast:

Image

@bpasero bpasero reopened this Feb 21, 2023
@bpasero bpasero added the verification-found Issue verification failed label Feb 21, 2023
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Feb 21, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 21, 2023
@bpasero bpasero added the verified Verification succeeded label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug editor-sticky-scroll insiders-released Patch has been released in VS Code Insiders verification-found Issue verification failed verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
6 participants
@bpasero @jrieken @mjbvz @aiday-mar @vscodenpa and others