-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iPadOS: Ctrl + C in terminal doesn’t kill running process #114009
Comments
Perhaps that is not the right sigint. |
One other piece of insight: this may not be limited to VSCode. @cdr has a product which includes a terminal in the browser. I’m able to reproduce the same issue (see line breaks at the bottom). |
As a temporary workaround, it works if you manually define the shortcut like so:
{
"key": "ctrl+c",
"command": "workbench.action.terminal.sendSequence",
"args": {
"text": "\u0003"
},
"when": "terminalFocus"
} Source: StackOverflow |
I found the root reason was iPad Safari report keyCode of ctrl-c as 13, which is not correct, reference from MDN, keyCode is a deprecated property; The key and code property is right, so I suggest just use key property, not keyCode, on the whole html page not just terminal. |
@meganrogge I'm still seeing this in codespace, am I testing the right environment? |
fixed w cc077af |
as another workaround, use |
Description
Hitting
ctrl
+c
with the terminal focused and a process running (i.e.yarn start
in a React app) does not kill the process.If someone is able to provide a good starting point, I would be willing to take a stab at this.
Steps to Reproduce:
yarn start
)ctrl
+c
Expected
Process (
yarn start
) should stop runningActual
Terminal receives new line
IMG_0009.MP4
Does this issue occur when all extensions are disabled?: Yes
Related:
The text was updated successfully, but these errors were encountered: