iPadOS: Ctrl + C doesn't kill running process

[jsjoeio]

ctrl + c keyboard shortcut/combination does not kill running process on iPad.

Details

• Browser and browser version: Chrome 87.0.4280.77
• OS version: iPadOS 14.5 (18E5164h)
• xterm.js version: 4.10.0

Steps to reproduce

1. Start demo in xterm.js with yarn start
2. Expose port (to access from iPad) with ngrok: ngrok http 3000
3. Open ngrok URL on iPad
4. Start a running process i.e. npm start on a create-react-app
5. After it starts and is running, try to kill process with ctrl + c on iPad

Expected

Keyboard shortcut kills process.

Actual

Enters new line. See recording:

RPReplay_Final1615247724.MP4

Related

• iPadOS: Ctrl + C in terminal doesn’t kill running process microsoft/vscode#114009
• Control-C not recognized from iPadOS coder/code-server#1343

[Tyriar]

We just worked around this in vscode, it's not the best fix because there's some bug in xterm.js causing this to happen, we just don't have an iPad to get to the bottom of it.

[jsjoeio]

@Tyriar I'm not super familiar with the xterm.js codebase, but I do have an iPad and motivation to help. I'd be happy to pitch in with some guidance!

[springhack]

I found this problem recently, it just because safari iOS report keyCode 13 while pressing ctrl-c;
I search MDN then I found the property keyCode is deprecated, so it's not a bug for safari, it's a bug for xterm.js and code-server;

I suggest just use property key but keyCode of KeyboardEvent, then resolve this problem.

MDN Link: https://developer.mozilla.org/zh-CN/docs/Web/API/KeyboardEvent/keyCode

[Tyriar]

@springhack seems like a bug in Safari as well if it's returning the key code for enter, but regardless moving to ctrlKey/altKey/shiftKey seems like the right thing to do.

[Tyriar]

Closing in favor of #1862 as that's about removing the keyCode usage.