settings.json intellisense suggests incorrect items

[hyangah]

• VSCode Version: 1.47.0-insider
  Commit: 376d9d9
  Date: 2020-07-03T10:26:01.724Z (3 days ago)

• OS Version: Darwin x64 18.7.0

Steps to Reproduce:

1. Install golang.go extension
2. Open "Settings", and find "Go: Language Server Experimental Features". Click "Edit in settings.json"
3. See incorrect items suggested

This is a new problem in 1.47.0-insiders. Not observed in 1.46.1

Does this issue occur when all extensions are disabled?: N/A

In 1.46.1

Note that clicking "Edit in settings.json" inserts

"go.languageServerExperimentalFeatures": {
    
 },

In 1.47.0-insiders

Note that clicking "Edit in settings.json" inserts

    "go.languageServerExperimentalFeatures": {
    
        "diagnostics": true,
        "documentLink": true
    },

[gjsjohnmurray]

@sandy081 probably #99854 (comment)

[gjsjohnmurray]

@sandy081 probably #99854 (comment)

New 1.47 behaviour of 'Edit in settings.json' reported by @hyangah is from #99854 and is correct I think. Completion no longer offers the two defined values because default entries got added. I guess it lists 'abc' type completions because Go extension maybe doesn't specify "additionalProperties": false

[sandy081]

Yeah it is because of #99854. As suggested in the issue it is better not to trigger the suggestion.

[hyangah]

I guess it lists 'abc' type completions because Go extension maybe doesn't specify "additionalProperties": false

I think I observed this issue first while testing golang/vscode-go#284 that adds additionalProperties. I didn't see any differences UX wise with and without the field, so I wondered what difference the PR would make.