Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad experience editing complex setting in settings.json #127452

Closed
joaomoreno opened this issue Jun 29, 2021 · 2 comments
Closed

Bad experience editing complex setting in settings.json #127452

joaomoreno opened this issue Jun 29, 2021 · 2 comments
Assignees
@sandy081
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@joaomoreno
Copy link
Member

I see a few paper-cuts in this whole thing:

  • The bogus "pub.name": false key-value pair gets inserted.
  • The suggestions are text-only so they should not come up at all.
  • The indentation on line 160 is wrong.

recording
@roblourens roblourens assigned sandy081 and unassigned roblourens Jun 29, 2021
@eamodio eamodio removed their assignment Jun 29, 2021
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Jun 29, 2021
@sandy081 sandy081 added this to the June 2021 milestone Jun 29, 2021
@sandy081
Copy link
Member

sandy081 commented Jul 1, 2021

/duplicate

#101822

@sandy081 sandy081 removed this from the June 2021 milestone Jul 1, 2021
@sandy081 sandy081 removed bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Jul 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@joaomoreno @roblourens @eamodio @sandy081 and others