New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json: make `additionalProperties` false for object type settings #284

Closed

9at8 wants to merge 1 commit into golang:master from 9at8:patch-1

Contributor

9at8 commented Jul 4, 2020 •

edited by hyangah

Loading

When I'm working on making simple non-nested object type settings editable from the settings GUI in vscode (microsoft/vscode#99635), and I think that setting additionalProperties to false for the objects that don't expect more properties would be great!

As per microsoft/vscode#101810, vscode (v1.48) will hide the "Add item" button if and only if additionalProperties is false and all known properties are present.


          Make additionalProperties false for object type settings

695aa78

I'm working on making simple non-nested object type settings editable from the settings GUI in vscode (microsoft/vscode#99635), and I think that setting `"additionalProperties": false` for the objects that don't expect more properties would be great!

googlebot commented Jul 4, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot added the cla: no label

Contributor Author

9at8 commented Jul 4, 2020

@googlebot I signed it!

googlebot commented Jul 4, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot added cla: yes and removed cla: no labels

Collaborator

gopherbot commented Jul 4, 2020

This PR (HEAD: 695aa78) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/240907 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Collaborator

gopherbot commented Jul 4, 2020

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/240907.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Jul 7, 2020

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240907.
After addressing review feedback, remember to publish your drafts!

hyangah mentioned this pull request

settings.json intellisense suggests incorrect items microsoft/vscode#101822

Open

Collaborator

gopherbot commented Jul 13, 2020

Message from Aditya Thakral:

Patch Set 1:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240907.
After addressing review feedback, remember to publish your drafts!

hyangah changed the title ~~Make additionalProperties false for object type settings~~ package.json: make additionalProperties false for object type settings

Collaborator

gopherbot commented Jul 15, 2020

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240907.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          package.json: make additionalProperties false for object type settings

e8e56a0

When I'm working on making simple non-nested object type settings editable from the settings GUI in vscode (microsoft/vscode#99635), and I think that setting `additionalProperties` to `false` for the objects that don't expect more properties would be great!

As per microsoft/vscode#101810, vscode (v1.48) will hide the "Add item" button if and only if `additionalProperties` is `false` and all known properties are present.

Change-Id: I92380610b24f7cd6ee790f2e020b9c689c3ff25b
GitHub-Last-Rev: 695aa78
GitHub-Pull-Request: #284
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/240907
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>

Collaborator

gopherbot commented Jul 15, 2020

Message from Hyang-Ah Hana Kim:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/240907.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Jul 15, 2020

This PR is being closed because golang.org/cl/240907 has been merged.

gopherbot closed this

9at8 deleted the patch-1 branch

July 15, 2020 22:12

gopherbot pushed a commit that referenced this pull request


          package.json: allow additional properties for alternateTools

e1603dd

In #284, we started
to use additionalProperties to support vscode's new setting UI
feature available for object type settings if the settings
accept only predefined properties.

 "go.alternateTools" can accept more tool names than those
specified in package.json. So, correct its additionalProperties
value.

Fixes #526

Change-Id: I72d2a7e72702d13bc74ed72a34a93756569bb041
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/248619
Reviewed-by: Suzy Mueller <[email protected]>

gopherbot pushed a commit that referenced this pull request


          [release] package.json: allow additional properties for alternateTools

903ccc7

In #284, we started
to use additionalProperties to support vscode's new setting UI
feature available for object type settings if the settings
accept only predefined properties.

 "go.alternateTools" can accept more tool names than those
specified in package.json. So, correct its additionalProperties
value.

Fixes #526

Change-Id: I72d2a7e72702d13bc74ed72a34a93756569bb041
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/248619
Reviewed-by: Suzy Mueller <[email protected]>
(cherry picked from commit e1603dd)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/252120
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels