forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yarn and code coverage #475
Merged
DonJayamanne
merged 169 commits into
microsoft:master
from
DonJayamanne:YarnAndCodeCoverage
Jan 3, 2018
Merged
Changes from 167 commits
Commits
Show all changes
169 commits
Select commit
Hold shift + click to select a range
ecc1ca9
Fix Microsoft/vscode#37627 (#1368)
octref 7c5778c
Version 0.7.0 of extension (#1381)
DonJayamanne 9d1bf82
Update README.md
DonJayamanne ffba179
Update README.md
DonJayamanne 905c713
sync fork with upstream
DonJayamanne acc2109
fix readme
DonJayamanne d470523
Merge branch 'master' of https://github.com/Microsoft/vscode-python
DonJayamanne d392e8b
merged upstream
DonJayamanne 92f775f
Merge remote-tracking branch 'upstream/master'
DonJayamanne 32a6e53
Merge remote-tracking branch 'upstream/master'
DonJayamanne 4b30f2c
Merge remote-tracking branch 'upstream/master'
DonJayamanne e396752
Merge remote-tracking branch 'upstream/master'
DonJayamanne eff4792
Merge remote-tracking branch 'upstream/master'
DonJayamanne 4553c28
Merge remote-tracking branch 'upstream/master'
DonJayamanne 3c6520a
Merge remote-tracking branch 'upstream/master'
DonJayamanne 966e516
Merge remote-tracking branch 'upstream/master'
DonJayamanne 63d2d65
Merge remote-tracking branch 'upstream/master'
DonJayamanne f6d469e
Merge remote-tracking branch 'upstream/master'
DonJayamanne 029e055
Merge remote-tracking branch 'upstream/master'
DonJayamanne e8c71c0
Merge remote-tracking branch 'upstream/master'
DonJayamanne 51cf9d2
Merge remote-tracking branch 'upstream/master'
DonJayamanne 7aadc43
Merge remote-tracking branch 'upstream/master'
DonJayamanne f0f5c59
Merge remote-tracking branch 'upstream/master'
DonJayamanne b2b9da9
Merge remote-tracking branch 'upstream/master'
DonJayamanne 30a4091
Merge remote-tracking branch 'upstream/master'
DonJayamanne b16d2f9
Merge remote-tracking branch 'upstream/master'
DonJayamanne c8db345
Merge remote-tracking branch 'upstream/master'
DonJayamanne 0df7f16
Merge remote-tracking branch 'upstream/master'
DonJayamanne 3ccc881
Merge remote-tracking branch 'upstream/master'
DonJayamanne bb0709e
Merge remote-tracking branch 'upstream/master'
DonJayamanne 2c19004
Merge remote-tracking branch 'upstream/master'
DonJayamanne 8f224ab
Merge remote-tracking branch 'upstream/master'
DonJayamanne 41b7080
Merge remote-tracking branch 'upstream/master'
DonJayamanne dab38dc
Merge remote-tracking branch 'upstream/master'
DonJayamanne ae22dd4
Merge remote-tracking branch 'upstream/master'
DonJayamanne d2340d2
Merge remote-tracking branch 'upstream/master'
DonJayamanne bcb8879
use new exec engine instead of spawning manually
DonJayamanne c6d6f50
refactor to use new execution framework
DonJayamanne 65a949b
refactor to use new exec framework
DonJayamanne c8559ea
fix linter errors
DonJayamanne 51a2802
refactor
DonJayamanne c778493
disable messages and copy config files
DonJayamanne a34a62c
remove old execution layer
DonJayamanne 9452d0e
misc
DonJayamanne 52bb7ae
Merge remote-tracking branch 'upstream/master'
DonJayamanne 5760886
merged master
DonJayamanne 1714f0c
Merge branch 'D' into FixDebuggerEnvVars
DonJayamanne 1bdc95d
fix tests
DonJayamanne 0313000
fix tests
DonJayamanne e7eb19e
disable message D102
DonJayamanne d09b3ef
fix bug introduced into test
DonJayamanne 0467d4c
fix tests
DonJayamanne ffdfd5d
fixed code review comments
DonJayamanne 59ff402
added tests for env variable parsing
DonJayamanne bab860f
remove metadata
DonJayamanne b6b2531
Merge remote-tracking branch 'upstream/master'
DonJayamanne 2b21cec
merged master
DonJayamanne 56d5c60
Merge branch 'FixDebuggerEnvVars' into EnvVarFixes
DonJayamanne 0ea674b
Merge branch 'RefactorJediAndOthers' into EnvVarFixes
DonJayamanne 09d2372
refactor environment variables parser
DonJayamanne 203e13e
fixed linter error
DonJayamanne 21601f2
Fixed code review comments
DonJayamanne 733f9a1
Merge branch 'RefactorJediAndOthers' into EnvVarFixes
DonJayamanne 24fa57e
added tests for env vars service
DonJayamanne 649b7e7
console could be null
DonJayamanne 8d8d2fc
Merge remote-tracking branch 'upstream/master'
DonJayamanne 6641ec8
merged master
DonJayamanne b65d7c0
merged master
DonJayamanne e6c9472
use new env variables service in jedi service
DonJayamanne bf2d5d5
fix #456
DonJayamanne 98b6993
add missing service registrations
DonJayamanne db84ded
Merge branch 'EnvVarFixes' into CommonToolExecution
DonJayamanne fcf3a24
yarn install
DonJayamanne 25e4b71
add missing service registration
DonJayamanne f0eff10
print version of python
DonJayamanne 81bec0a
Merge branch 'EnvVarFixes' into CommonToolExecution
DonJayamanne bc34320
disable osx
DonJayamanne 390d43e
revert to npm with yarn globally
DonJayamanne c6f9295
initial
DonJayamanne eba3c51
code coverage
DonJayamanne 3bbbaaa
add missing service registration
DonJayamanne ca0a55f
Merge branch 'CommonToolExecution' into YarnAndCodeCoverage
DonJayamanne 6b90c29
upload builds
DonJayamanne 9be7b6a
test upload of builds
DonJayamanne 9e60bdf
move exports to the top
DonJayamanne 90e2352
upload after success
DonJayamanne a6525ab
run all tests
DonJayamanne 5ab101b
fix branch name
DonJayamanne 0f43394
initial
DonJayamanne 1ade067
escape paths
DonJayamanne 3e1e146
enable builds
DonJayamanne 0c871eb
disable azure telemetry
DonJayamanne f8a9171
disable azure telemetry
DonJayamanne 4f6152e
turn off build
DonJayamanne fa41b20
remove incorrect command
DonJayamanne ab8377d
remove invalid command
DonJayamanne f5dfde6
fix case insensitive searches for files on windows tests
DonJayamanne 4aa9329
fix test search
DonJayamanne 19df1b6
fix linter
DonJayamanne 5a73d54
comment
DonJayamanne a45b38d
disable uploads of coverage and builds
DonJayamanne 1225184
fix path checks
DonJayamanne 063808b
Fix path checks on windows
DonJayamanne ce87814
merge
DonJayamanne d21d59c
fix path checks
DonJayamanne 50053e3
enable py3 tests
DonJayamanne 2fd956e
enable other modules
DonJayamanne ab5453b
Merge branch 'AppVeyor' of https://github.com/DonJayamanne/pythonVSCo…
DonJayamanne 856c0c0
enable test for multi root as well
DonJayamanne 7cad8dc
we don't need coverage or uploads from apveyor
DonJayamanne 3d7e91d
better post build setup
DonJayamanne 36b7bb0
build package when releasing
DonJayamanne 84c4351
remove asserts from before and after test hooks
DonJayamanne 7fc9120
Merge branch 'YarnAndCodeCoverage' into AppVeyor
DonJayamanne d306d56
revert build step
DonJayamanne 37a72a5
fix multiple resolves and resolve when windows close
DonJayamanne 4750999
use env service instead of child_process
DonJayamanne 86eb43f
swallow the exception
DonJayamanne ead278c
fix shebang detection
DonJayamanne 30169f9
Merge branch 'CompleteCodeExec' into AppVeyor
DonJayamanne 7266325
Merge branch 'CompleteCodeExec' into YarnAndCodeCoverage
DonJayamanne 97c888c
Merge branch 'CompleteCodeExec' into AppVeyor
DonJayamanne 0a6f625
Merge branch 'AppVeyor' of https://github.com/DonJayamanne/pythonVSCo…
DonJayamanne 3773820
fix vscode warnings when accessing configs
DonJayamanne 634582d
simplify code to close editors
DonJayamanne 7f265d6
put limit on wait time
DonJayamanne 3bef891
simpler if
DonJayamanne f455263
clean up closing of windows
DonJayamanne 04969dc
add debug statements
DonJayamanne 6a337b2
more logging
DonJayamanne 3874a30
and more logging
DonJayamanne d444de4
and again
DonJayamanne e9d74c3
remove logging
DonJayamanne 2511f12
fix calling of async functions without callbacks
DonJayamanne ea84e1d
remove npm
DonJayamanne a49aa3b
update contrib guidelines
DonJayamanne 61f23fb
Merge branch 'YarnAndCodeCoverage' into AppVeyor
DonJayamanne 7e2d820
removed activation of documents
DonJayamanne 97589d6
fixed tests
DonJayamanne 67daea1
add missing decorators
DonJayamanne b01b98d
fix tests
DonJayamanne 50061be
use yarn instead of npm in appveyor
DonJayamanne b31bafd
do not activate document
DonJayamanne 95e4bda
remove app veyor file
DonJayamanne 30d0bb5
remove imports of 'reflect-metadata'
DonJayamanne 5eb11dc
Merge branch 'EnvVarFixes' into CommonToolExecution
DonJayamanne 1f5fe49
Merge branch 'CommonToolExecution' into CompleteCodeExec
DonJayamanne 9c91ca3
Merge branch 'CompleteCodeExec' into YarnAndCodeCoverage
DonJayamanne e53e48c
fix linter warnings
DonJayamanne ffc5084
use codecov instead of coveralls
DonJayamanne 2988211
upload to coverio
DonJayamanne 2846eda
format condition
DonJayamanne 230e270
added missing colon
DonJayamanne 3fcbdf1
clean travis
DonJayamanne 5b5f69d
add json report
DonJayamanne 00d3fdd
upload using bash script
DonJayamanne 6ac63bf
conditionally upload coverage reports
DonJayamanne c425a55
Merge remote-tracking branch 'upstream/master'
DonJayamanne f8b9eac
merge master
DonJayamanne b55ad34
Merge branch 'CommonToolExecution' into YarnAndCodeCoverage
DonJayamanne 8855bf7
Merge branch 'CommonToolExecution' into CompleteCodeExec
DonJayamanne 3963217
Merge remote-tracking branch 'upstream/master'
DonJayamanne 9ab1013
merge master
DonJayamanne ab5ab4d
Merge branch 'CompleteCodeExec' into YarnAndCodeCoverage
DonJayamanne 9cf62a5
remove unwanted files
DonJayamanne a696f2a
Merge remote-tracking branch 'upstream/master'
DonJayamanne 8019956
merged master;
DonJayamanne 95517f7
resolve code review
DonJayamanne 3bc6bd3
fix code review issues
DonJayamanne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,3 +9,5 @@ node_modules | |
__pycache__ | ||
npm-debug.log | ||
**/.mypy_cache/** | ||
!yarn.lock | ||
coverage/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,6 @@ | ||
language: python | ||
cache: pip | ||
|
||
addons: | ||
apt: | ||
sources: | ||
- ubuntu-toolchain-r-test | ||
packages: | ||
- gcc-4.9 | ||
- g++-4.9 | ||
- gcc-4.9-multilib | ||
- g++-4.9-multilib | ||
- libgtk2.0-0 | ||
- libx11-dev | ||
- libxkbfile-dev | ||
- libsecret-1-dev | ||
- python-dev | ||
matrix: | ||
include: | ||
# # Use the built in venv for linux builds | ||
|
@@ -43,17 +29,27 @@ before_install: | | |
source ./.nvm/nvm.sh | ||
nvm install 8.9.1 | ||
nvm use 8.9.1 | ||
npm i -g [email protected] | ||
npm config set python `which python` | ||
if [ "$TRAVIS_OS_NAME" == "osx" ]; then | ||
pyenv install $PYTHON | ||
pyenv global $PYTHON | ||
fi | ||
export TRAVIS_PYTHON_PATH=`which python` | ||
install: | ||
- pip install --upgrade -r requirements.txt | ||
- npm install | ||
- npm run vscode:prepublish | ||
- yarn | ||
|
||
script: | ||
- npm test --silent | ||
- yarn run clean | ||
- yarn run vscode:prepublish | ||
- yarn run cover:enable | ||
- yarn run testSingleWorkspace --silent | ||
- if [ $TRAVIS_UPLOAD_COVERAGE == "true" ]; then | ||
bash <(curl -s https://codecov.io/bash); | ||
fi | ||
- yarn run clean | ||
- yarn run vscode:prepublish | ||
- yarn run cover:enable | ||
- yarn run testMultiWorkspace --silent | ||
- if [ $TRAVIS_UPLOAD_COVERAGE == "true" ]; then | ||
bash <(curl -s https://codecov.io/bash); | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,80 +1,96 @@ | ||
// A launch configuration that compiles the extension and then opens it inside a new window | ||
{ | ||
"version": "0.1.0", | ||
"configurations": [ | ||
{ | ||
"name": "Launch Extension", | ||
"type": "extensionHost", | ||
"request": "launch", | ||
"runtimeExecutable": "${execPath}", | ||
"args": [ | ||
"--extensionDevelopmentPath=${workspaceFolder}" | ||
], | ||
"stopOnEntry": false, | ||
"sourceMaps": true, | ||
"outFiles": [ | ||
"${workspaceFolder}/out/**/*.js" | ||
], | ||
"preLaunchTask": "Compile" | ||
}, | ||
{ | ||
"name": "Launch Extension as debugServer", // https://code.visualstudio.com/docs/extensions/example-debuggers | ||
"type": "node", | ||
"request": "launch", | ||
"program": "${workspaceFolder}/out/client/debugger/Main.js", | ||
"stopOnEntry": false, | ||
"args": [ | ||
"--server=4711" | ||
], | ||
"sourceMaps": true, | ||
"outFiles": [ | ||
"${workspaceFolder}/out/client/**/*.js" | ||
], | ||
"cwd": "${workspaceFolder}", | ||
"preLaunchTask": "Compile" | ||
}, | ||
{ | ||
"name": "Launch Tests", | ||
"type": "extensionHost", | ||
"request": "launch", | ||
"runtimeExecutable": "${execPath}", | ||
"args": [ | ||
"${workspaceFolder}/src/test", | ||
"--extensionDevelopmentPath=${workspaceFolder}", | ||
"--extensionTestsPath=${workspaceFolder}/out/test" | ||
], | ||
"stopOnEntry": false, | ||
"sourceMaps": true, | ||
"outFiles": [ | ||
"${workspaceFolder}/out/**/*.js" | ||
], | ||
"preLaunchTask": "Compile" | ||
}, | ||
{ | ||
"name": "Launch Multiroot Tests", | ||
"type": "extensionHost", | ||
"request": "launch", | ||
"runtimeExecutable": "${execPath}", | ||
"args": [ | ||
"${workspaceFolder}/src/testMultiRootWkspc/multi.code-workspace", | ||
"--extensionDevelopmentPath=${workspaceFolder}", | ||
"--extensionTestsPath=${workspaceFolder}/out/test" | ||
], | ||
"stopOnEntry": false, | ||
"sourceMaps": true, | ||
"outFiles": [ | ||
"${workspaceFolder}/out/**/*.js" | ||
], | ||
"preLaunchTask": "Compile" | ||
} | ||
], | ||
"compounds": [ | ||
{ | ||
"name": "Extension + Debugger", | ||
"configurations": [ | ||
"Launch Extension", | ||
"Launch Extension as debugServer" | ||
] | ||
} | ||
] | ||
"version": "0.1.0", | ||
"configurations": [ | ||
{ | ||
"name": "Launch Extension", | ||
"type": "extensionHost", | ||
"request": "launch", | ||
"runtimeExecutable": "${execPath}", | ||
"args": [ | ||
"--extensionDevelopmentPath=${workspaceFolder}" | ||
], | ||
"stopOnEntry": false, | ||
"sourceMaps": true, | ||
"outFiles": [ | ||
"${workspaceFolder}/out/**/*.js" | ||
], | ||
"preLaunchTask": "Compile" | ||
}, | ||
{ | ||
"name": "Launch Extension as debugServer", // https://code.visualstudio.com/docs/extensions/example-debuggers | ||
"type": "node", | ||
"request": "launch", | ||
"program": "${workspaceFolder}/out/client/debugger/Main.js", | ||
"stopOnEntry": false, | ||
"args": [ | ||
"--server=4711" | ||
], | ||
"sourceMaps": true, | ||
"outFiles": [ | ||
"${workspaceFolder}/out/client/**/*.js" | ||
], | ||
"cwd": "${workspaceFolder}", | ||
"preLaunchTask": "Compile" | ||
}, | ||
{ | ||
"name": "Launch Tests", | ||
"type": "extensionHost", | ||
"request": "launch", | ||
"runtimeExecutable": "${execPath}", | ||
"args": [ | ||
"${workspaceFolder}/src/test", | ||
"--extensionDevelopmentPath=${workspaceFolder}", | ||
"--extensionTestsPath=${workspaceFolder}/out/test" | ||
], | ||
"stopOnEntry": false, | ||
"sourceMaps": true, | ||
"outFiles": [ | ||
"${workspaceFolder}/out/**/*.js" | ||
], | ||
"preLaunchTask": "Compile" | ||
}, | ||
{ | ||
"name": "Launch Multiroot Tests", | ||
"type": "extensionHost", | ||
"request": "launch", | ||
"runtimeExecutable": "${execPath}", | ||
"args": [ | ||
"${workspaceFolder}/src/testMultiRootWkspc/multi.code-workspace", | ||
"--extensionDevelopmentPath=${workspaceFolder}", | ||
"--extensionTestsPath=${workspaceFolder}/out/test" | ||
], | ||
"stopOnEntry": false, | ||
"sourceMaps": true, | ||
"outFiles": [ | ||
"${workspaceFolder}/out/**/*.js" | ||
], | ||
"preLaunchTask": "Compile" | ||
}, | ||
{ | ||
"name": "Launch Tests (with code coverage)", | ||
"type": "extensionHost", | ||
"request": "launch", | ||
"runtimeExecutable": "${execPath}", | ||
"args": [ | ||
"${workspaceFolder}/src/test", | ||
"--extensionDevelopmentPath=${workspaceFolder}", | ||
"--extensionTestsPath=${workspaceFolder}/out/test" | ||
], | ||
"stopOnEntry": false, | ||
"sourceMaps": true, | ||
"outFiles": [ | ||
"${workspaceFolder}/out/**/*.js" | ||
] | ||
} | ||
], | ||
"compounds": [ | ||
{ | ||
"name": "Extension + Debugger", | ||
"configurations": [ | ||
"Launch Extension", | ||
"Launch Extension as debugServer" | ||
] | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,23 @@ | ||
// Place your settings in this file to overwrite default and user settings. | ||
{ | ||
"files.exclude": { | ||
"out": true, // set this to true to hide the "out" folder with the compiled JS files | ||
"**/*.pyc": true, | ||
"**/__pycache__": true, | ||
"node_modules": true, | ||
".vscode-test": true, | ||
"**/.mypy_cache/**": true, | ||
"**/.ropeproject/**": true | ||
}, | ||
"search.exclude": { | ||
"out": true // set this to false to include "out" folder in search results | ||
}, | ||
"typescript.tsdk": "./node_modules/typescript/lib", // we want to use the TS server from our node_modules folder to control its version | ||
"tslint.enable": true, | ||
"python.linting.enabled": false, | ||
"python.unitTest.promptToConfigure": false, | ||
"python.workspaceSymbols.enabled": false, | ||
"files.exclude": { | ||
"out": true, // set this to true to hide the "out" folder with the compiled JS files | ||
"**/*.pyc": true, | ||
"**/__pycache__": true, | ||
"node_modules": true, | ||
".vscode-test": true, | ||
"**/.mypy_cache/**": true, | ||
"**/.ropeproject/**": true | ||
}, | ||
"search.exclude": { | ||
"out": true, // set this to false to include "out" folder in search results | ||
"coverage": true | ||
}, | ||
"typescript.tsdk": "./node_modules/typescript/lib", // we want to use the TS server from our node_modules folder to control its version | ||
"tslint.enable": true, | ||
"python.linting.enabled": false, | ||
"python.unitTest.promptToConfigure": false, | ||
"python.workspaceSymbols.enabled": false, | ||
"python.formatting.provider": "none", | ||
"files.insertFinalNewline": true | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,34 @@ | ||
.vscode/** | ||
typings/** | ||
out/test/** | ||
out/src/** | ||
out/pythonFiles/** | ||
out/testMultiRootWkspc/** | ||
test/** | ||
src/** | ||
scripts/** | ||
**/*.map | ||
.gitignore | ||
.gitmodules | ||
.editorconfig | ||
.eslintrc | ||
.gitattributes | ||
images/**/*.gif | ||
images/**/*.png | ||
tsconfig.json | ||
typings.json | ||
coverconfig.json | ||
tslint.json | ||
tsfmt.json | ||
gulpfile.js | ||
pythonFiles/**/*.pyc | ||
requirements.txt | ||
vsc-extension-quickstart.md | ||
.travis.yml | ||
webpack.config.js | ||
yarn.lock | ||
coverage/** | ||
CODE_OF_CONDUCT.md | ||
CODING_STANDARDS.md | ||
CONTRIBUTING.md | ||
ISSUE_TEMPLATE.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
{ | ||
"enabled": false, | ||
"relativeSourcePath": "../client", | ||
"relativeCoverageDir": "../../coverage", | ||
"ignorePatterns": [ | ||
"**/node_modules/**" | ||
], | ||
"reports": [ | ||
"text-summary", | ||
"json-summary", | ||
"json", | ||
"html", | ||
"lcov", | ||
"lcovonly" | ||
], | ||
"verbose": false | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you explicitly not ignoring
yarn.lock
instead of just not listing it in the.gitignore
file?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be getting ignored on my pc and mac. Hence figured i might as well be explicit.
Not sure what I've done to exclude these (i don't recall changing this in my global config)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, fair enough. I would check your global
.gitignore
file to see what that has.