Yarn and code coverage #475

DonJayamanne · 2017-12-22T18:38:59Z

Fixes Move to using yarn #421 (move from npm to yarn)
Fixes Add code coverage #464 (code coverage of the extension code)
Fixes to some unit tests that were failing just on Windows

Archive of 0.7.0

* 'master' of https://github.com/Microsoft/vscode-python: Fixes #56 list all environments (#219) Fixes #57 Disable activation on debugging (#220) Fixes #26 Do not run linters when linters are disabled (#222)

* upstream/master: Fix typo in README.md (#252) Disable linter without workspaces (#241)

* upstream/master: Fix feedback service (#246) Fix django context initializer (#248) disable generation of tags file upon extension load (#264)

* upstream/master: Resolve pythonPath before comparing it to shebang (#273)

* upstream/master: Fixes #22 to Detect anaconda from known locations (#221) Use workspaceFolder token instead of workspaceRoot (#267) Fix registry lookup response (#224) Fix issues when running without debugging and debugged code terminates (#249)

* upstream/master: Fix debugging tests (#304)

* upstream/master: Remove jupyter functionality in favor of Jupyter extension (#302) Drop Python 2 URLs (#307)

* upstream/master: Remove setting python.formatting.formatOnSave in favor of the vs code setting (#312)

* upstream/master: Remove setting linting.lintOnTextChange as it was never implemented (#315)

* upstream/master: Fix travis build error (#326)

* upstream/master: add new npm deps with improved gulp for dev (#328)

* upstream/master: Update version of inversify package (#329)

* upstream/master: Document our dev process (#330)

* upstream/master: Document contribution to the code along with coding standards (#321)

* upstream/master: Add Simplified Chinese translation of commands (#240)

* upstream/master: Fix package.json (#347)

* upstream/master: #34, #110 - suppress Intellisense in strings and comments (#339) Re-factor code python execution framework (#345)

* upstream/master: Fix linters to make use of the new python code execution framework (#360) Update the versioning scheme (#356) Make npm happy in regards to line endings (#357)

* upstream/master: Ensure python path is not set if already set in user settings (#369) Use 'an' rather than 'a' before vowel words (#373)

* upstream/master: Use new environment variable parser (#362)

* CommonToolExecution: remove imports of 'reflect-metadata'

* CompleteCodeExec: remove imports of 'reflect-metadata'

* upstream/master: Refactor parsing of environment variables (after 439) (#466) Refactor extension to remove old way of spawning python processes (#439)

* CommonToolExecution: Refactor parsing of environment variables (after 439) (#466) Refactor extension to remove old way of spawning python processes (#439)

* upstream/master: Common execution for python tool or module (#468)

* CompleteCodeExec: Common execution for python tool or module (#468)

* upstream/master: Complete refactoring of code to use new code exec engine (#493)

brettcannon · 2018-01-03T22:52:26Z

.gitignore

@@ -9,3 +9,5 @@ node_modules
 __pycache__
 npm-debug.log
 **/.mypy_cache/**
+!yarn.lock


Why are you explicitly not ignoring yarn.lock instead of just not listing it in the .gitignore file?

Seems to be getting ignored on my pc and mac. Hence figured i might as well be explicit.
Not sure what I've done to exclude these (i don't recall changing this in my global config)

OK, fair enough. I would check your global .gitignore file to see what that has.

brettcannon · 2018-01-03T22:57:06Z

src/test/testRunner.ts

@@ -0,0 +1,225 @@
+/*---------------------------------------------------------
+ * Copyright (C) Microsoft Corporation. All rights reserved.


brettcannon · 2018-01-03T22:57:41Z

src/test/testRunner.ts

+        const remappedCollector: istanbul.Collector = remapIstanbul.remap(coverage, {
+            warn: warning => {
+                // We expect some warnings as any JS file without a typescript mapping will cause this.
+                // By default, we'll skip printing these to the console as it clutters it up


Missing a period.

brettcannon · 2018-01-03T22:58:14Z

src/test/testRunner.ts

+    // private transformer?: Instrumenter;
+    private sourceFiles: string[] = [];
+    private instrumenter: Instrumenter;
+    // private matchFn: any = undefined;


Commented-out code.

brettcannon · 2018-01-03T23:02:01Z

src/test/testRunner.ts

+                decache(fullPath);
+            });
+
+        // this.matchFn = function (file): boolean { return fileMap[file]; };


Commented-out code.

brettcannon · 2018-01-03T23:02:11Z

src/test/testRunner.ts

+        // this.matchFn = function (file): boolean { return fileMap[file]; };
+        const matchFn = (file: string) => fileMap.has(file);
+        this.sourceFiles = Array.from(fileMap.keys());
+        // this.matchFn.files = Object.keys(fileMap);


Commented-out code.

brettcannon · 2018-01-03T23:02:23Z

src/test/testRunner.ts

+        // this.transformer = this.instrumenter.instrumentSync.bind(this.instrumenter);
+        const transformer = this.instrumenter.instrumentSync.bind(this.instrumenter);
+        const hookOpts = { verbose: false, extensions: ['.js'] };
+        // istanbul.hook.hookRequire(this.matchFn, this.transformer, hookOpts);


Commented-out code.

* upstream/master: Improve interpreter selection on different platforms (#517) Yarn and code coverage (#475)

octref and others added 30 commits November 3, 2017 13:11

Fix microsoft/vscode#37627 (#1368)

ecc1ca9

Version 0.7.0 of extension (#1381)

7c5778c

Archive of 0.7.0

Update README.md

9d1bf82

Update README.md

ffba179

sync fork with upstream

905c713

fix readme

acc2109

merged upstream

d392e8b

Merge remote-tracking branch 'upstream/master'

92f775f

* upstream/master: Fix typo in README.md (#252) Disable linter without workspaces (#241)

Merge remote-tracking branch 'upstream/master'

32a6e53

* upstream/master: Fix feedback service (#246) Fix django context initializer (#248) disable generation of tags file upon extension load (#264)

Merge remote-tracking branch 'upstream/master'

4b30f2c

* upstream/master: Resolve pythonPath before comparing it to shebang (#273)

Merge remote-tracking branch 'upstream/master'

eff4792

Merge remote-tracking branch 'upstream/master'

4553c28

Merge remote-tracking branch 'upstream/master'

3c6520a

* upstream/master: Fix debugging tests (#304)

Merge remote-tracking branch 'upstream/master'

966e516

* upstream/master: Remove jupyter functionality in favor of Jupyter extension (#302) Drop Python 2 URLs (#307)

Merge remote-tracking branch 'upstream/master'

63d2d65

* upstream/master: Remove setting python.formatting.formatOnSave in favor of the vs code setting (#312)

Merge remote-tracking branch 'upstream/master'

f6d469e

* upstream/master: Remove setting linting.lintOnTextChange as it was never implemented (#315)

Merge remote-tracking branch 'upstream/master'

029e055

* upstream/master: Fix travis build error (#326)

Merge remote-tracking branch 'upstream/master'

e8c71c0

* upstream/master: add new npm deps with improved gulp for dev (#328)

Merge remote-tracking branch 'upstream/master'

51cf9d2

* upstream/master: Update version of inversify package (#329)

Merge remote-tracking branch 'upstream/master'

7aadc43

* upstream/master: Document our dev process (#330)

Merge remote-tracking branch 'upstream/master'

f0f5c59

* upstream/master: Document contribution to the code along with coding standards (#321)

Merge remote-tracking branch 'upstream/master'

b2b9da9

* upstream/master: Add Simplified Chinese translation of commands (#240)

Merge remote-tracking branch 'upstream/master'

30a4091

* upstream/master: Fix package.json (#347)

Merge remote-tracking branch 'upstream/master'

b16d2f9

* upstream/master: #34, #110 - suppress Intellisense in strings and comments (#339) Re-factor code python execution framework (#345)

Merge remote-tracking branch 'upstream/master'

c8db345

* upstream/master: Fix linters to make use of the new python code execution framework (#360) Update the versioning scheme (#356) Make npm happy in regards to line endings (#357)

Merge remote-tracking branch 'upstream/master'

0df7f16

* upstream/master: Ensure python path is not set if already set in user settings (#369) Use 'an' rather than 'a' before vowel words (#373)

Merge remote-tracking branch 'upstream/master'

3ccc881

* upstream/master: Use new environment variable parser (#362)

Merge remote-tracking branch 'upstream/master'

bb0709e

DonJayamanne added 15 commits January 2, 2018 11:33

Merge branch 'CommonToolExecution' into CompleteCodeExec

1f5fe49

* CommonToolExecution: remove imports of 'reflect-metadata'

Merge branch 'CompleteCodeExec' into YarnAndCodeCoverage

9c91ca3

* CompleteCodeExec: remove imports of 'reflect-metadata'

fix linter warnings

e53e48c

use codecov instead of coveralls

ffc5084

upload to coverio

2988211

format condition

2846eda

added missing colon

230e270

clean travis

3fcbdf1

add json report

5b5f69d

upload using bash script

00d3fdd

conditionally upload coverage reports

6ac63bf

Merge remote-tracking branch 'upstream/master'

c425a55

* upstream/master: Refactor parsing of environment variables (after 439) (#466) Refactor extension to remove old way of spawning python processes (#439)

merge master

f8b9eac

Merge branch 'CommonToolExecution' into YarnAndCodeCoverage

b55ad34

* CommonToolExecution: Refactor parsing of environment variables (after 439) (#466) Refactor extension to remove old way of spawning python processes (#439)

Merge branch 'CommonToolExecution' into CompleteCodeExec

8855bf7

* CommonToolExecution: Refactor parsing of environment variables (after 439) (#466) Refactor extension to remove old way of spawning python processes (#439)

DonJayamanne changed the title ~~WIP - Yarn and code coverage (after 493)~~ Yarn and code coverage Jan 3, 2018

DonJayamanne added 3 commits January 3, 2018 13:31

Merge remote-tracking branch 'upstream/master'

3963217

* upstream/master: Common execution for python tool or module (#468)

merge master

9ab1013

Merge branch 'CompleteCodeExec' into YarnAndCodeCoverage

ab5ab4d

* CompleteCodeExec: Common execution for python tool or module (#468)

DonJayamanne requested a review from brettcannon January 3, 2018 21:34

DonJayamanne added 3 commits January 3, 2018 13:39

remove unwanted files

9cf62a5

Merge remote-tracking branch 'upstream/master'

a696f2a

* upstream/master: Complete refactoring of code to use new code exec engine (#493)

merged master;

8019956

brettcannon approved these changes Jan 3, 2018

View reviewed changes

DonJayamanne added 2 commits January 3, 2018 15:11

resolve code review

95517f7

fix code review issues

3bc6bd3

DonJayamanne merged commit 9853956 into microsoft:master Jan 3, 2018

DonJayamanne deleted the YarnAndCodeCoverage branch January 4, 2018 19:49

DonJayamanne added a commit that referenced this pull request Jan 9, 2018

Merge remote-tracking branch 'upstream/master'

a31e659

* upstream/master: Improve interpreter selection on different platforms (#517) Yarn and code coverage (#475)

lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Yarn and code coverage #475

Yarn and code coverage #475

DonJayamanne commented Dec 22, 2017 •

edited

Loading

brettcannon Jan 3, 2018

DonJayamanne Jan 3, 2018

brettcannon Jan 3, 2018

brettcannon Jan 3, 2018

brettcannon Jan 3, 2018

brettcannon Jan 3, 2018

brettcannon Jan 3, 2018

brettcannon Jan 3, 2018

brettcannon Jan 3, 2018

		@@ -0,0 +1,225 @@
		/*---------------------------------------------------------
		* Copyright (C) Microsoft Corporation. All rights reserved.

Yarn and code coverage #475

Yarn and code coverage #475

Conversation

DonJayamanne commented Dec 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DonJayamanne commented Dec 22, 2017 •

edited

Loading