Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont automatically inject PYTHONSTARTUP #24346

Merged
merged 46 commits into from
Nov 4, 2024
Merged

dont automatically inject PYTHONSTARTUP #24346

merged 46 commits into from
Nov 4, 2024

Commits on Oct 28, 2024

  1. dont automatically inject pystartup

    @anthonykim1
    anthonykim1 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    154a3e2 View commit details
    Browse the repository at this point in the history

  2. create test to make sure PYTHONSTARTUP not auto injected

    @anthonykim1
    anthonykim1 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    377e700 View commit details
    Browse the repository at this point in the history

  3. make compiler happy

    @anthonykim1
    anthonykim1 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    d60f310 View commit details
    Browse the repository at this point in the history

  4. compile

    @anthonykim1
    anthonykim1 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6d8ba24 View commit details
    Browse the repository at this point in the history

  5. make sure to be safe when checking for property potentitally empty

    @anthonykim1
    anthonykim1 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    37cd45b View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. what is going on with timeout

    @anthonykim1
    anthonykim1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    fbcebd2 View commit details
    Browse the repository at this point in the history

  2. try with done() ?

    @anthonykim1
    anthonykim1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1bbd0bc View commit details
    Browse the repository at this point in the history

  3. is it because of experiment value

    @anthonykim1
    anthonykim1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3aa86bf View commit details
    Browse the repository at this point in the history

  4. try adding async and see if that helps

    @anthonykim1
    anthonykim1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    5f53706 View commit details
    Browse the repository at this point in the history

  5. try to add more test

    @anthonykim1
    anthonykim1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d327903 View commit details
    Browse the repository at this point in the history

  6. adjust timeout to see if it helps with potential race condition

    @anthonykim1
    anthonykim1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2db9394 View commit details
    Browse the repository at this point in the history

  7. parenthesis

    @anthonykim1
    anthonykim1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8b5eeb0 View commit details
    Browse the repository at this point in the history

  8. add condition in executeCommand in case onDidEndTerminalShellExecutio… 

    …n never returns
    @anthonykim1
    anthonykim1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    7c0b405 View commit details
    Browse the repository at this point in the history

  9. remove wrong test

    @anthonykim1
    anthonykim1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    0ccb053 View commit details
    Browse the repository at this point in the history

  10. env should be undefined if not explicitly passed in

    @anthonykim1
    anthonykim1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    40ff863 View commit details
    Browse the repository at this point in the history

  11. add comment

    @anthonykim1
    anthonykim1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    7dd3f83 View commit details
    Browse the repository at this point in the history

  12. allow smoke test on windows

    @anthonykim1
    anthonykim1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3c3bfc9 View commit details
    Browse the repository at this point in the history

  13. reduce to 5 second

    @anthonykim1
    anthonykim1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    c1a51ad View commit details
    Browse the repository at this point in the history

  14. fix after feedback

    @anthonykim1
    anthonykim1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4ea5c67 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. fix test, {} to undefined

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8fb2e24 View commit details
    Browse the repository at this point in the history

  2. set default shell to pwsh

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    83dbb90 View commit details
    Browse the repository at this point in the history

  3. passing on local, fail on CI - try longer time

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2f3e787 View commit details
    Browse the repository at this point in the history

  4. try increasing time

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    eaa78f2 View commit details
    Browse the repository at this point in the history

  5. make sure shell integration is disabled on smart send smoke test

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    d12ae35 View commit details
    Browse the repository at this point in the history

  6. setting to make sure to enable REPLSmartSend

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f7f8ef6 View commit details
    Browse the repository at this point in the history

  7. add log to debug in CI

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6b4b097 View commit details
    Browse the repository at this point in the history

  8. try different way in service,ts

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    edb91ba View commit details
    Browse the repository at this point in the history

  9. more descriptive comment, ensure env is only passed in when setting e… 

    …nabled
    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    eaaf338 View commit details
    Browse the repository at this point in the history

  10. clean up

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    de99824 View commit details
    Browse the repository at this point in the history

  11. clean up

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    dbb2e2a View commit details
    Browse the repository at this point in the history

  12. add TODO for future

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    038c98e View commit details
    Browse the repository at this point in the history

  13. improve comment

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    aa07144 View commit details
    Browse the repository at this point in the history

  14. update comment

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    490ef8b View commit details
    Browse the repository at this point in the history

  15. reset to original timeout number

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    c896ce7 View commit details
    Browse the repository at this point in the history

  16. remove unncessary exitcode promise

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    59a3116 View commit details
    Browse the repository at this point in the history

  17. add _shellIntegrationEnabled

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4fd5369 View commit details
    Browse the repository at this point in the history

  18. add _terminalFirstLaunched field to not call onDidChangeTerminalShell… 

    …Integration everytime
    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b40f53f View commit details
    Browse the repository at this point in the history

  19. add log for executeCommand

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e527be7 View commit details
    Browse the repository at this point in the history

  20. remove unused

    @anthonykim1
    anthonykim1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    446e95c View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. remove unnecessary comment

    @anthonykim1
    anthonykim1 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1435329 View commit details
    Browse the repository at this point in the history

  2. make smoke test use pwsh

    @anthonykim1
    anthonykim1 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    12f7b3e View commit details
    Browse the repository at this point in the history

  3. stop complaining about unknown import

    @anthonykim1
    anthonykim1 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    4a2a5d0 View commit details
    Browse the repository at this point in the history

  4. append to standardTest to update setting

    @anthonykim1
    anthonykim1 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c56fb61 View commit details
    Browse the repository at this point in the history

  5. no more importing vscode

    @anthonykim1
    anthonykim1 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d4b0227 View commit details
    Browse the repository at this point in the history

  6. dont add setting programmatically for smoke test

    @anthonykim1
    anthonykim1 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    9e0d33d View commit details
    Browse the repository at this point in the history

  7. clean up

    @anthonykim1
    anthonykim1 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    6fba2a8 View commit details
    Browse the repository at this point in the history