dont automatically inject PYTHONSTARTUP #24346
Conversation
anthonykim1
added
bug
anthonykim1
changed the title
|
smoke test that used to only fail for windows is now also failing for linux #24105 |
|
fixed root cause, now further making sure sendText when shell integration is enabled but we never get event from onDidEndShellIntegration. |
| traceVerbose(`Shell Integration is enabled, executeCommand: ${commandLine}`); | ||
| }), | ||
| // Once shell integration is active, hearing back from onDidEndTerminalShellExecution should not take too long. | ||
| new Promise<undefined>((resolve) => { |
There was a problem hiding this comment.
Found that without this, smoke test would time out.
Havent heard issue from user about execution taking forever, so in real-life I think onDidEndTerminalShellExecution gets back in reasonable amout of time.
There was a problem hiding this comment.
still added the promise just in case there is a case where onDidEndTerminalShellExecution never gets fired, we don't want people stuck and waiting for their execution result forever.
There was a problem hiding this comment.
You would have already scheduled something to run on the terminal. Doesn't sendText mean that it will now add yet another command? Also, in practice Promise.race returns when one of the two finishes, wouldn't it still sendText. there is nothing stopping the setTimeout function from running,
Are you sure that CI is using the new powershell, and not the old one. Have we ensured to set the default shell type to be Powershell when testing this.
There was a problem hiding this comment.
I got the smoke tests to use pwsh now :) 12f7b3e
But Im not sure if it is using the newer pwsh or the slower one
…Integration everytime
Resolves microsoft#24345 and microsoft#24290 and microsoft#24105 remove automatic injection from before so only thing that allows shell integration to user for Python terminal REPL is the setting itself.
…#6) Resolves #24345 and #24290 and #24105 remove automatic injection from before so only thing that allows shell integration to user for Python terminal REPL is the setting itself. Co-authored-by: Anthony Kim <[email protected]>
Resolves #24345 and #24290 and #24105
remove automatic injection from before so only thing that allows shell integration to user for Python terminal REPL is the setting itself.