Relax highlighting rules on HTML element names #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of requiring a name to match an existing HTML element, this relaxes the restrictions to: - starting with [a-zA-Z] (matching the HTML parser WICG/webcomponents#239 (comment)) - then continuing with anything other than a space, forward slash or closing angle bracket This is similar to the fix to the following issue in the HTML syntax highlighting repo (and actually depends on the "derivative" syntax that was created for that issue): textmate/html.tmbundle#92
|
|
|
Ah just realized this changed the test results for the issue 42 test... pushed a fix now. |
|
Hm, tests are failing: They run for me locally though :( Is there any way I can see the output on CI? I suppose turning off "silent" or something...? |
|
Looks like the output is printed and only issue-42.md` is still failing: https://travis-ci.org/microsoft/vscode-markdown-tm-grammar/jobs/573494345#L279 I'll merge this PR since it is unrelated to that change |
|
Ok sounds good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring a name to match an existing HTML element, this relaxes the
restrictions to:
[a-zA-Z](matching the HTML parser [Custom]: "are" custom element names ASCII characters, or MUST they be ASCII characters? WICG/webcomponents#239 (comment))angle bracket
text.html.derivativethat is already used by VS Code (see custom 'html' tags are in red color textmate/html.tmbundle#92 and microsoft/vscode@cfc2a22)This is similar to the fix to the following issue in the HTML syntax
highlighting repo (and actually depends on the "derivative" syntax that was
created for that issue):
textmate/html.tmbundle#92
Closes #53