Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown Highlighting: Unknown Tags #53

Closed
karlhorky opened this issue Aug 18, 2019 · 0 comments · Fixed by #54
Closed

Markdown Highlighting: Unknown Tags #53

karlhorky opened this issue Aug 18, 2019 · 0 comments · Fixed by #54

Comments

@karlhorky
Copy link
Contributor

Note: Half of this issue was previously opened in #49

The Markdown syntax highlighting grammar doesn't recognize unknown HTML elements (such as web components or components in frameworks):

Screen Shot 2019-08-14 at 15 57 10

Compare that with the HTML grammar highlighting, which would be the preferable output:

Screen Shot 2019-08-14 at 16 02 35


Background: In @silvenon's MDX extension, I would like React component highlighting to work properly inline (see silvenon/vscode-mdx#9).

While this wouldn't get us all of the way there, it would at least be a step in the right direction (and would also benefit normal Markdown users).


Prior art (HTML Textmate Grammar adding custom HTML tags):

textmate/html.tmbundle#92
microsoft/vscode@cfc2a22


I will submit a pull request with tests for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant