Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait on shell port instead of heart beat port #7887

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Wait on shell port instead of heart beat port #7887

merged 1 commit into from
Oct 11, 2021

Conversation

DonJayamanne
Copy link
Contributor

For #7334

@DonJayamanne DonJayamanne requested a review from a team as a code owner October 11, 2021 16:58
@codecov-commenter
Copy link

Codecov Report

Merging #7887 (a30bf10) into main (e66061c) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #7887   +/-   ##
=====================================
  Coverage     70%     70%           
=====================================
  Files        361     361           
  Lines      22153   22153           
  Branches    3357    3357           
=====================================
+ Hits       15583   15585    +2     
+ Misses      5211    5210    -1     
+ Partials    1359    1358    -1     
Impacted Files Coverage Δ
...lient/datascience/kernel-launcher/kernelProcess.ts 74% <ø> (ø)
src/client/datascience/baseJupyterSession.ts 69% <0%> (+<1%) ⬆️

@DonJayamanne DonJayamanne merged commit 752372f into main Oct 11, 2021
@DonJayamanne DonJayamanne deleted the issue7334 branch October 11, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants