Wait on shell port instead of heart beat port

microsoft · Oct 11, 2021 · a30bf10 · a30bf10
1 parent e66061c
commit a30bf10
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/news/2 Fixes/7334.md b/news/2 Fixes/7334.md
@@ -0,0 +1,2 @@
+Changes to how we check if kernels have started (as a result now suppor kernels such as [Wolfram](https://github.com/WolframResearch/WolframLanguageForJupyter)).
+
diff --git a/src/client/datascience/kernel-launcher/kernelProcess.ts b/src/client/datascience/kernel-launcher/kernelProcess.ts
@@ -171,7 +171,8 @@ export class KernelProcess implements IKernelProcess {
         try {
             const tcpPortUsed = require('tcp-port-used') as typeof import('tcp-port-used');
             await Promise.race([
-                tcpPortUsed.waitUntilUsed(this.connection.hb_port, 200, timeout),
+                // Wait on shell port as this is used for communications (hence shell port is guaranteed to be used, where as heart beat isn't).
+                tcpPortUsed.waitUntilUsed(this.connection.shell_port, 200, timeout),
                 deferred.promise,
                 createPromiseFromCancellation({
                     token: cancelToken,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Changes to how we check if kernels have started (as a result now suppor kernels such as [Wolfram](https://github.com/WolframResearch/WolframLanguageForJupyter)).