This repository has been archived by the owner on Nov 30, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR on-boards the java container into the image build process and is part of work for #154.
Currently it will output the following image variants for Java versions:
...based on the contents of
base.Dockerfile
.Note that we generally we drop no longer supported versions of Java from the build process once the version is out of support. However, existing tags, just with an older image.
Note that this does not include Java 8 because the Java extension seems to require it be set to Java home, and there appears to be no good way with symlinks to get this to work consistently because
"java.configuration.runtimes"
appears to force you to enter a specific"name"
value. It would need its own dedicated build. (As an aside, I'm really surprised there isn't a"java.extension.home"
property or something like that added.)In the next VS Code release, the default Dockerfile in the container will use this instead, but without the "dev-" prefix. The image includes
nvm
, but doesn't install Node in the image since it isn't always needed for Java development, but can be useful in web development involving Java.It also has scripts to install Maven and Gradle referenced from both dockerfiles, but they are not in the image given
mvnw
/gradlew
are often used.//cc: @testforstephen @akaroml - Let me know what you think.