-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Tracking] Onboard additional definitions to image build #154
Comments
I can help with the Python ones (and I'm totally fine with automatic generation), but the Functions ones are probably best left up to the Functions team (who know me and can loop me in as necessary). |
@brettcannon Thanks Brett! One question for the Python definitions is whether just doing latest for Python 3 is enough if we pre-build images. People will be able to easily get back to the Python Dockerfile to use it if they prefer (the build system will add links into devcontainer.json and the stub Dockerfile that gets added), but do we need sub revisions? (e.g. Python 3.8, 3.7, 3.6) |
I'd like to understand the work involved here to onboard. Can you summarize @Chuxel? |
@Chuxel it's such a per-project choice that for your own sanity I would just go with latest and expect people to manually tweak as necessary if they need a different version. But if you're feeling generous then you could list support for all versions supported upstream. |
For Python Azure Functions, we'll probably want to keep it at 3.6 for another week or two, then update it to 3.7 once the next Azure Functions extension is released with better 3.7 support. I created that dev container so I'm happy to help with it and any of the other Azure Functions ones. |
@brettcannon Yeah, that was kind of my thinking as well. With Node we're doing ones for in support LTS versions, which is typically only two - 10, 12 (8 is going away very soon). Anything that is more of an example like the node-mongo is just latest LTS. For Python, we could start with latest major version (e.g. 3 -- since 2 is about out of support) and just use a tagging scheme to make it easy to add others if needed. (e.g. @anthonychu Sounds great! One of the things this new setup also does is allow the use of common script (though currently only one per Dockerfile). I've got basic scripts to install common things like git, zsh, etc for the trial set. Once those are up I can let everyone know in the event that makes it easier to maintain the different variations of the Functions ones. @TylerLeonhardt Most of the actual build is automated, so really the discussion is:
I haven't merged in the changes since I'm OOF this week, but ultimately there's effectively a json config file that can be dropped in a definition folder along with an update to a MCR feed that causes it all to happen. I'll provide more specifics soon! |
Can help with Perl if needed. |
At this point I'm going to close out this issue in favor of new ones on an as-needed basis. We have the core images that Microsoft is focusing on maintaining at this point. Pre-building community contributed definitions is not something we plan to do because of a combination of lack of knowledge and a need for a full-time maintainer that also is managing security patching. |
After #140 is complete, we can start to on-board more images. In some cases, changes to the definition are required while in others it's a matter of going through the process.
On-board to automatic image generation
Need to coordinate with the appropriate teams where applicable. In some cases, the team may prefer to build their own images - which works just fine as well.
Azure Functions - Coordinate with appropriate teams/authors. @jeffhollan @fiveisprime @testforstephen @brunoborges @anthonychu @brettcannonFunctions team is looking into doing their own images rather than building out of this repo.Others less used definitions to consider:
Incoming to consider:
Update to base off of MCR image (once available)
Need to coordinate with 3rd party author where applicable.
Salesforce, Puppet image is maintained by companies already.
The text was updated successfully, but these errors were encountered: