Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support parsing substring with ' ' space #1648

Closed
wants to merge 29 commits into from

Conversation

elahehrashedi
Copy link
Contributor

@elahehrashedi elahehrashedi commented Feb 4, 2021

Add support parsing define variables that are in the form of a string, e.g., and also variables that include a space in the string:

target_compile_definitions(testPRa PUBLIC AWESOME="'pr a'")
target_compile_definitions(testPRb PUBLIC AWESOME="'pr b'")
set(CMAKE_CXX_COMPILER "c:/program files (x86)/mingw-w64/i686-8.1.0-posix-dwarf-rt_v6-rev0/mingw32/bin/g++.exe")

bug:
main:
#969
#1414

duplicates:
#1493
#1565

src/shlex.ts Outdated Show resolved Hide resolved
src/shlex.ts Outdated Show resolved Hide resolved
@elahehrashedi
Copy link
Contributor Author

The test from the wrong input file was running. I had to recreate the branch.

@elahehrashedi elahehrashedi deleted the ella/space-compdb branch March 16, 2021 20:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants