support non-trivial command-lines for Compile Active File #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in particular macro definitions containing quotes and spaces fixes microsoft#969 fixes microsoft#1221
|
Rebased. |
|
@Trass3r Thank you for your contribution. Some part of this PR has been considered in: #1648. In the mentioned PR, there is a fix for substrings that include ' ' space. I can see your comments that the arguments haven't been used, however, we needed to fix the parsing algorithm to send the correct set of arguments to IntelliSense. |
|
This is not just about spaces but more so about arbitrarily complex shell expressions, one case was |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular macro definitions containing quotes and spaces.
The code was trying to be too clever, splitting the commandline into arguments and re-merging (the split args weren't even used/modified).
Just let the shell do its job.
NB: this doesn't fix #1227 (comment)
@bobbrow @andreeis