Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial tasks support #1268

Merged
merged 41 commits into from
Oct 16, 2020
Merged

Initial tasks support #1268

merged 41 commits into from
Oct 16, 2020

Conversation

poterba
Copy link
Contributor

@poterba poterba commented May 27, 2020

This change addresses items #1264, #1234

In cases with file build command context, empty ws uri is possible. Additional check added.

@poterba poterba changed the title Check added Empty workspace URI handled May 27, 2020
@poterba poterba marked this pull request as ready for review May 27, 2020 17:49
src/folders.ts Outdated Show resolved Hide resolved
src/folders.ts Outdated Show resolved Hide resolved
src/folders.ts Outdated Show resolved Hide resolved
src/folders.ts Outdated Show resolved Hide resolved
@poterba poterba changed the title Empty workspace URI handled WIP: Usage of commands from tasks fix Jun 11, 2020
@poterba poterba closed this Jun 17, 2020
@bobbrow
Copy link
Member

bobbrow commented Jun 17, 2020

We're still interested in taking this change. Are you planning to resubmit it?

@poterba

This comment has been minimized.

@poterba poterba reopened this Jun 19, 2020
@poterba

This comment has been minimized.

@poterba
Copy link
Contributor Author

poterba commented Jul 6, 2020

Since we're providing own task type - do we need tasksBuildCommand as external command?

PS: As I've sticked to existing functionality in tasks (such as tasksBuildCommand) - I'd like to see something similar for configuration.
PPS: Why configuration isn't cancellable?

@poterba

This comment has been minimized.

@poterba

This comment has been minimized.

@bobbrow
Copy link
Member

bobbrow commented Jul 7, 2020

Sorry I haven't had a chance to take a look at your updates yet. I will do it soon.

If we make a change to CI, we will probably move to Azure Pipelines like the cpptools extension. This project's CI is wrapped up in a rather involved Powershell script, so we haven't come up with a cost for migrating that to another system yet.

@poterba
Copy link
Contributor Author

poterba commented Jul 8, 2020

UPD: misunderstanding removed

There's another part I've forgot about: buildAll.
The point is: buildAll passed to build array of ${command:cmake.buildAll} and first project path. Corresponding expand.expandString promise failed in driver.ts.

@poterba poterba changed the title WIP: Usage of commands from tasks fix Usage of commands from tasks fix Jul 9, 2020
@poterba
Copy link
Contributor Author

poterba commented Jul 9, 2020

Ready to go (w/o test)

@julianxhokaxhiu
Copy link

Can someone please take a look at this?

@poterba poterba changed the title Usage of commands from tasks fix Initial tasks support Oct 7, 2020
@bobbrow bobbrow added this to the 1.5.0 milestone Oct 8, 2020
@andreeis andreeis merged commit a9f059b into microsoft:develop Oct 16, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants