Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacBook Pro touchbar support #1263

Merged
merged 24 commits into from
Oct 16, 2020
Merged

MacBook Pro touchbar support #1263

merged 24 commits into from
Oct 16, 2020

Conversation

poterba
Copy link
Contributor

@poterba poterba commented May 25, 2020 •
edited
Loading

This change addresses item #499

The following changes are proposed:
Contributing Build, Launch and Debug commands to MacBook Pro Touch Bar.

@msftclas
Copy link

msftclas commented May 25, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@poterba poterba changed the title Initial touchbar support MacBook Pro touchbar support May 27, 2020
@bobbrow
Copy link
Member

bobbrow commented Jun 5, 2020

This looks pretty straightforward, but I don't have a way to validate this change since we don't have a mac with touchbar support to test on. Are you able to share a photo of what the touchbar looks like when these are enabled? Uploading it to this PR would be fine.

@bobbrow bobbrow requested a review from a team June 5, 2020 18:38
andreeis
andreeis reviewed Jun 5, 2020
View reviewed changes
package.json Show resolved Hide resolved
@poterba
Copy link
Contributor Author

poterba commented Jun 8, 2020 •
edited
Loading

Added quickstart btw

IMG_0348
IMG_0349
IMG_0350

@poterba
Copy link
Contributor Author

poterba commented Jun 8, 2020 •
edited
Loading

Since these commands use commands same as tasks, this PR needs another fix.

bobbrow
bobbrow approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@bobbrow bobbrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we waiting on PR #1268 before we commit this? Or is it ready to go now?

@poterba
Copy link
Contributor Author

poterba commented Jul 7, 2020 •
edited
Loading

Are we waiting on PR #1268 before we commit this? Or is it ready to go now?

For now it's working only with no files open VSCode - in other cases it's providing currently open file as argument (if I'm not mistaken - checked some time ago).
Fix for this was initial change in PR #1268 - but, as you know, it became something bigger.

UPD: I've messed this up, file wasn't an argument - but property 'fsPath' of undefined {} error still reproducible.

@bobbrow bobbrow added this to the 1.5.0 milestone Oct 8, 2020
@andreeis andreeis merged commit e0db022 into microsoft:develop Oct 16, 2020
@bobbrow
Copy link
Member

bobbrow commented Oct 16, 2020

We now build an installable extension with each commit. You can test this out by downloading cmake-tools.vsix from https://github.com/microsoft/vscode-cmake-tools/actions/runs/310694927 and using the "install from vsix" command in VS Code.

@poterba poterba deleted the dev/vptrbv/touchbar branch March 2, 2021 18:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bobbrow bobbrow bobbrow approved these changes

@andreeis andreeis andreeis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@poterba @msftclas @bobbrow @andreeis