-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Resource & Storage SDK to T2 #1050
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
36ee042
Update packages
nturinski 98212e0
Convert resource sdk to T2 and use new creds
nturinski 67fe10e
Bump package version
nturinski e7a9385
PR fixes
nturinski a25d6b8
Add credentials2 prop to use T2 clients
nturinski 4d29f11
Remove credential2 from ISubscriptionContext, use GenericCred where n…
nturinski 716dc75
Enforce some service cred stuff, use generic creds
nturinski c758ef2
export uiUtils.listAllIterator
nturinski 5514380
Export type for index.d.ts
nturinski 6219682
Factor out BasicAuth and TokenCreds from index.d.ts
nturinski bb3d53c
Update ui/index.d.ts
nturinski e55dca3
Add newlines to files
nturinski 2b5f0ef
Merge branch 'nat/t2packages' of https://github.com/microsoft/vscode-…
nturinski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this returns
Promise<any | null>
instead ofPromise<TokenResponse | AccessToken | null>
? Even though we do the same thing forsignRequest
above and returnPromise<any>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's to keep it more loose so that other versions of credentials could be accepted. For example,
BasicAuthenticationCredentials
returnsWebResourceLike
whereas theServiceClientCredentials
returnsWebResource
. We originally did that forsignRequest
because different versions of "@azure/ms-rest-js" would change the credential interface. I figured the same could happen withgetToken
.Here's an example with the typing screwing up here: Azure/azure-sdk-for-js#10045
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that version of
signRequest
that returnsWebResource
is older? It looks like the current version returnsWebResourceLike
: https://github.com/Azure/ms-rest-js/blob/f6f0d92d79a1dfa8d92ff0891b88bc6b7a349e69/lib/credentials/serviceClientCredentials.ts