error when create a ApplicationInsightsManagementClient instance

[VanyLaw]

• Package Name: @azure/arm-appinsights ; @azure/arm-botservice
• Package Version: newest in npm
• Operating system: window
• nodejs
  • version:
• browser
  • name/version:
• typescript
  • version:
• Is the bug related to documentation in
  • README.md
  • source code documentation
  • SDK API docs on https://docs.microsoft.com

Describe the bug
I can not new a ApplicationInsightsManagementClient instance(come from @azure/arm-appinsights) and AzureBotService instance (come from @azure/arm-botservice) if I only have a accessToken.

I create a TokenCredentials instance with accessToken, which is implement the ServiceClientCredentials, and try to use this as the parameter to create ApplicationInsightsManagementClient and AzureBotService, but failed. I guess it's because the version of @azure/ms-rest-js package which is dependency in @azure/arm-appinsights and @azure/arm-botservice is out of dated.

Could anyone can update the dependency package version of @azure/arm-appinsights and @azure/arm-botservice? Or could you tell me how to create those two types of instances just by accessToken?

To Reproduce
Steps to reproduce the behavior:

1. const token = new TokenCredentials(accessToken);
2. new ApplicationInsightsManagementClient(token ````); // error parameter.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

[qiaozha]

@changlong-liu Can you please take a look at this issue? Thanks

[VanyLaw]

FYI. Error messages are:
error TS2345: Argument of type 'import("/Composer/plugins/node_modules/@azure/ms-rest-js/es/lib/credentials/serviceClientCredentials").ServiceClientCredentials' is not assignable to parameter of type 'import("/Composer/plugins/node_modules/@azure/arm-appinsights/node_modules/@azure/ms-rest-js/es/lib/credentials/serviceClientCredentials").ServiceClientCredentials'.
Types of property 'signRequest' are incompatible.
Type '(webResource: WebResourceLike) => Promise' is not assignable to type '(webResource: WebResource) => Promise'.
Types of parameters 'webResource' and 'webResource' are incompatible.
Type 'WebResource' is not assignable to type 'WebResourceLike'.
Types of property 'shouldDeserialize' are incompatible.
Type 'boolean | ((response: import("Composer/plugins/node_modules/@azure/arm-appinsights/node_modules/@azure/ms-rest-js/es/lib/httpOperationResponse").HttpOperationResponse) => boolean) | undefined' is not assignable to type 'boolean | ((response: import("/Composer/plugins/node_modules/@azure/ms-rest-js/es/lib/httpOperationResponse").HttpOperationResponse) => boolean) | undefined'.
Type '(response: HttpOperationResponse) => boolean' is not assignable to type 'boolean | ((response: HttpOperationResponse) => boolean) | undefined'.
Type '(response: import("/Composer/plugins/node_modules/@azure/arm-appinsights/node_modules/@azure/ms-rest-js/es/lib/httpOperationResponse").HttpOperationResponse) => boolean' is not assignable to type '(response: import("/Composer/plugins/node_modules/@azure/ms-rest-js/es/lib/httpOperationResponse").HttpOperationResponse) => boolean'.
Types of parameters 'response' and 'response' are incompatible.
Type 'import("/Composer/plugins/node_modules/@azure/ms-rest-js/es/lib/httpOperationResponse").HttpOperationResponse' is not assignable to type 'import("/Composer/plugins/node_modules/@azure/arm-appinsights/node_modules/@azure/ms-rest-js/es/lib/httpOperationResponse").HttpOperationResponse'.
The types of 'request.headers' are incompatible between these types.
Property '_headersMap' is missing in type 'HttpHeadersLike' but required in type 'HttpHeaders'.

818 const appinsightsClient = new ApplicationInsightsManagementClient(tokenCredential, this.subId);
~~~~~~~~~~~~~~~

../../node_modules/@azure/arm-appinsights/node_modules/@azure/ms-rest-js/es/lib/httpHeaders.d.ts:24:22
24 private readonly _headersMap;
~~~~~~~~~~~
'_headersMap' is declared here.

src/botProjectDeploy.ts:853:54 - error TS2345: Argument of type 'import("/Composer/plugins/node_modules/@azure/ms-rest-js/es/lib/credentials/serviceClientCredentials").ServiceClientCredentials' is not assignable to parameter of type 'import("/Composer/plugins/node_modules/@azure/arm-appinsights/node_modules/@azure/ms-rest-js/es/lib/credentials/serviceClientCredentials").ServiceClientCredentials'.

853 const botServiceClient = new AzureBotService(tokenCredential, this.subId);
~~~~~~~~~~~~~~~

Found 2 errors.

[ghost]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @azmonapplicationinsights.

[changlong-liu]

Hi applicationinsights service team, the JS SDK is using a old version of ms-rest, would you confirm we need to release a new SDK based on latest swagger? Thank you.

[ramya-rao-a]

@changlong-liu The last update to @azure/arm-appinsights was almost a year ago. Since then, the swagger spec has been updated multiple times and corresponding automated PRs have been opened in this repo as well, but none were merged. See https://github.com/Azure/azure-sdk-for-js/pulls?q=is%3Apr+appinsights+is%3Aclosed+in%3Atitle

I would take that as an indication that the service team has been making the swagger updates assuming that the automation would take care of updating the packages.

So, I would highly recommend updating the package and not only unblock the customer, but also allow them to use the new features.

cc @tofriedl and @majastrz, the last two people to update the swagger for confirmation

[changlong-liu]

Hi @ramya-rao-a , thanks for comments. I'll involve you in the mail thread we discussing this with the issue submitter and ApplicationInsights service team.

The reasons we didn't release new package by ourselves are:

1. the swagger has changed a lot since last release, we don't know whether they are ready in service side.
2. has breaking changes
3. the current swagger has definition issues, it's hard to say that it's ready for release.

[ghost]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @sgellock.

[changlong-liu]

Update for current status:
Appinsights: swagger issue is fixed(Azure/azure-rest-api-specs#10228). The service team is fixing issues in service side, and we can expect to release sdk after service is ready.
Botservice: don’t get response from service side yet.

[luhan2017]

@stevengum , Hi, could you please help submit a release request for bot service?

[stevengum]

@luhan2017 @VanyLaw @changlong-liu, sorry for the delay the release request has been filed.

[changlong-liu]

Hi @stevengum , @VanyLaw , the botservice JS package is available here: https://microsoft.sharepoint.com/:u:/t/AzureManagementExperience/EesAOwtz9LZPsOex0y0AI54BegRKJUFDa5Oz4zNPqiYQcQ?e=TDGtYM

Would you verify it before public release? Thank you!

[VanyLaw]

Hi @changlong-liu , it can work in my site. Thanks!

[changlong-liu]

Hi @VanyLaw , the botservice is released here: https://www.npmjs.com/package/@azure/arm-botservice/v/2.0.0

[changlong-liu]

Hi @VanyLaw , shall I know whether have any issue on the packages, shall we close this issue?

[ramya-rao-a]

Closing this issue as both the @azure/arm-appinsights and @azure/arm-botservice have been updated appropriately