update dependencies version in appinsights and botservice packages #10123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge this PR. There still need some discussion about the change. |
|
Thanks for your efforts here @VanyLaw, but we cannot accept this PR in its current form. Both the packages being touched in this PR are auto-generated ones and we don't manually make changes to these. @changlong-liu is following up with the service teams to figure out which version of the swagger spec representing the service should be used to re-generate these packages. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the ms-rest-js package is out of dated in appinsights and botservice packages. It cause problem when I use those two package with the newest ms-rest-js package.
ref to #10045