Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ErrorResponse and OperationsListResult from livetoken_API.js #10228

Conversation

tokaplan
Copy link
Contributor

@tokaplan tokaplan commented Jul 22, 2020

…on, substituting with references to WebTestResults_API.json.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

…on, substituting with references to WebTestResults_API.json.
@tokaplan tokaplan self-assigned this Jul 22, 2020
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 22, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 724fba3 with merge commit 60ff1f4. SDK Automation 13.0.17.20200619.4
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.ApplicationInsights [View full logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 22, 2020

    azure-sdk-for-java - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 22, 2020

    azure-sdk-for-python - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 724fba3 with merge commit 60ff1f4. SDK Automation 13.0.17.20200619.4
    • ️✔️azure-mgmt-applicationinsights [View full logs]  [Release SDK Changes]
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-applicationinsights
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-applicationinsights
      [after_scripts|python] INFO:__main__:Default API version will be: v2020_03_01_preview
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 0.733% size of original (original: 71898 chars, delta: 527 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model ApplicationInsightsComponent has a new parameter ingestion_mode
      [ChangeLog]   - Model ApplicationInsightsComponent has a new parameter la_migration_date

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 22, 2020

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 22, 2020

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 22, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 724fba3 with merge commit 60ff1f4. SDK Automation 13.0.17.20200619.4
    • ️✔️@azure/arm-appinsights [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/applicationInsightsManagementClient.js → ./dist/arm-appinsights.js...
      [npmPack] created ./dist/arm-appinsights.js in 457ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/[email protected]
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 6.0kB   esm/operations/analyticsItems.js                                   
      [npmPack] npm notice 505B    esm/models/analyticsItemsMappers.js                                
      [npmPack] npm notice 6.1kB   esm/operations/annotations.js                                      
      [npmPack] npm notice 470B    esm/models/annotationsMappers.js                                   
      [npmPack] npm notice 5.3kB   esm/operations/aPIKeys.js                                          
      [npmPack] npm notice 499B    esm/models/aPIKeysMappers.js                                       
      [npmPack] npm notice 3.0kB   esm/applicationInsightsManagementClient.js                         
      [npmPack] npm notice 2.6kB   esm/applicationInsightsManagementClientContext.js                  
      [npmPack] npm notice 213.5kB dist/arm-appinsights.js                                            
      [npmPack] npm notice 76.3kB  dist/arm-appinsights.min.js                                        
      [npmPack] npm notice 2.1kB   esm/operations/componentAvailableFeatures.js                       
      [npmPack] npm notice 552B    esm/models/componentAvailableFeaturesMappers.js                    
      [npmPack] npm notice 3.5kB   esm/operations/componentCurrentBillingFeatures.js                  
      [npmPack] npm notice 514B    esm/models/componentCurrentBillingFeaturesMappers.js               
      [npmPack] npm notice 2.1kB   esm/operations/componentFeatureCapabilities.js                     
      [npmPack] npm notice 472B    esm/models/componentFeatureCapabilitiesMappers.js                  
      [npmPack] npm notice 6.1kB   esm/operations/componentLinkedStorageAccountsOperations.js         
      [npmPack] npm notice 905B    esm/models/componentLinkedStorageAccountsOperationsMappers.js      
      [npmPack] npm notice 2.0kB   esm/operations/componentQuotaStatus.js                             
      [npmPack] npm notice 456B    esm/models/componentQuotaStatusMappers.js                          
      [npmPack] npm notice 10.9kB  esm/operations/components.js                                       
      [npmPack] npm notice 990B    esm/models/componentsMappers.js                                    
      [npmPack] npm notice 7.6kB   esm/operations/exportConfigurations.js                             
      [npmPack] npm notice 507B    esm/models/exportConfigurationsMappers.js                          
      [npmPack] npm notice 7.2kB   esm/operations/favorites.js                                        
      [npmPack] npm notice 442B    esm/models/favoritesMappers.js                                     
      [npmPack] npm notice 345B    esm/models/index.js                                                
      [npmPack] npm notice 1.0kB   esm/operations/index.js                                            
      [npmPack] npm notice 1.7kB   esm/operations/liveToken.js                                        
      [npmPack] npm notice 426B    esm/models/liveTokenMappers.js                                     
      [npmPack] npm notice 68.1kB  esm/models/mappers.js                                              
      [npmPack] npm notice 3.6kB   esm/operations/operations.js                                       
      [npmPack] npm notice 522B    esm/models/operationsMappers.js                                    
      [npmPack] npm notice 8.4kB   esm/models/parameters.js                                           
      [npmPack] npm notice 5.2kB   esm/operations/proactiveDetectionConfigurations.js                 
      [npmPack] npm notice 857B    esm/models/proactiveDetectionConfigurationsMappers.js              
      [npmPack] npm notice 1.0kB   rollup.config.js                                                   
      [npmPack] npm notice 2.0kB   esm/operations/webTestLocations.js                                 
      [npmPack] npm notice 503B    esm/models/webTestLocationsMappers.js                              
      [npmPack] npm notice 9.9kB   esm/operations/webTests.js                                         
      [npmPack] npm notice 866B    esm/models/webTestsMappers.js                                      
      [npmPack] npm notice 6.3kB   esm/operations/workbooks.js                                        
      [npmPack] npm notice 878B    esm/models/workbooksMappers.js                                     
      [npmPack] npm notice 8.0kB   esm/operations/workItemConfigurations.js                           
      [npmPack] npm notice 543B    esm/models/workItemConfigurationsMappers.js                        
      [npmPack] npm notice 1.7kB   package.json                                                       
      [npmPack] npm notice 457B    tsconfig.json                                                      
      [npmPack] npm notice 2.6kB   esm/operations/analyticsItems.d.ts.map                             
      [npmPack] npm notice 3.4kB   esm/operations/analyticsItems.js.map                               
      [npmPack] npm notice 213B    esm/models/analyticsItemsMappers.d.ts.map                          
      [npmPack] npm notice 226B    esm/models/analyticsItemsMappers.js.map                            
      [npmPack] npm notice 2.5kB   esm/operations/annotations.d.ts.map                                
      [npmPack] npm notice 3.4kB   esm/operations/annotations.js.map                                  
      [npmPack] npm notice 224B    esm/models/annotationsMappers.d.ts.map                             
      [npmPack] npm notice 237B    esm/models/annotationsMappers.js.map                               
      [npmPack] npm notice 2.3kB   esm/operations/aPIKeys.d.ts.map                                    
      [npmPack] npm notice 3.0kB   esm/operations/aPIKeys.js.map                                      
      [npmPack] npm notice 209B    esm/models/aPIKeysMappers.d.ts.map                                 
      [npmPack] npm notice 222B    esm/models/aPIKeysMappers.js.map                                   
      [npmPack] npm notice 1.3kB   esm/applicationInsightsManagementClient.d.ts.map                   
      [npmPack] npm notice 1.9kB   esm/applicationInsightsManagementClient.js.map                     
      [npmPack] npm notice 505B    esm/applicationInsightsManagementClientContext.d.ts.map            
      [npmPack] npm notice 1.4kB   esm/applicationInsightsManagementClientContext.js.map              
      [npmPack] npm notice 494.2kB dist/arm-appinsights.js.map                                        
      [npmPack] npm notice 64.3kB  dist/arm-appinsights.min.js.map                                    
      [npmPack] npm notice 829B    esm/operations/componentAvailableFeatures.d.ts.map                 
      [npmPack] npm notice 1.1kB   esm/operations/componentAvailableFeatures.js.map                   
      [npmPack] npm notice 250B    esm/models/componentAvailableFeaturesMappers.d.ts.map              
      [npmPack] npm notice 263B    esm/models/componentAvailableFeaturesMappers.js.map                
      [npmPack] npm notice 1.4kB   esm/operations/componentCurrentBillingFeatures.d.ts.map            
      [npmPack] npm notice 1.8kB   esm/operations/componentCurrentBillingFeatures.js.map              
      [npmPack] npm notice 247B    esm/models/componentCurrentBillingFeaturesMappers.d.ts.map         
      [npmPack] npm notice 260B    esm/models/componentCurrentBillingFeaturesMappers.js.map           
      [npmPack] npm notice 833B    esm/operations/componentFeatureCapabilities.d.ts.map               
      [npmPack] npm notice 1.1kB   esm/operations/componentFeatureCapabilities.js.map                 
      [npmPack] npm notice 228B    esm/models/componentFeatureCapabilitiesMappers.d.ts.map            
      [npmPack] npm notice 241B    esm/models/componentFeatureCapabilitiesMappers.js.map              
      [npmPack] npm notice 2.4kB   esm/operations/componentLinkedStorageAccountsOperations.d.ts.map   
      [npmPack] npm notice 3.2kB   esm/operations/componentLinkedStorageAccountsOperations.js.map     
      [npmPack] npm notice 455B    esm/models/componentLinkedStorageAccountsOperationsMappers.d.ts.map
      [npmPack] npm notice 468B    esm/models/componentLinkedStorageAccountsOperationsMappers.js.map  
      [npmPack] npm notice 817B    esm/operations/componentQuotaStatus.d.ts.map                       
      [npmPack] npm notice 1.1kB   esm/operations/componentQuotaStatus.js.map                         
      [npmPack] npm notice 212B    esm/models/componentQuotaStatusMappers.d.ts.map                    
      [npmPack] npm notice 225B    esm/models/componentQuotaStatusMappers.js.map                      
      [npmPack] npm notice 4.8kB   esm/operations/components.d.ts.map                                 
      [npmPack] npm notice 6.6kB   esm/operations/components.js.map                                   

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 23, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @qiaozha qiaozha merged commit 60ff1f4 into Azure:master Jul 24, 2020
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    …Azure#10228)
    
    * Removing ErrorResponse and OperationsListResult from livetoken_API.json, substituting with references to WebTestResults_API.json.
    
    * Fix attempt.
    
    * Typo fix
    
    * Reverting.
    
    * Adjust "Operation" name for uniqueness.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants