Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a promise.allSettle instead of a for loop that resolves one at a time #883

Merged
merged 7 commits into from
Jul 2, 2024
Merged

Use a promise.allSettle instead of a for loop that resolves one at a time #883

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4203e3a
Use a promise.allSettle instead of a for loop that resolves one at a …
nturinski Jun 28, 2024
59e5114
Merge branch 'main' into nat/promiseAllSettle
nturinski Jun 28, 2024
801d733
PR feedback
nturinski Jun 28, 2024
1b3bed8
Merge branch 'nat/promiseAllSettle' of https://github.com/microsoft/v…
nturinski Jun 28, 2024
3aa5362
localize
nturinski Jun 28, 2024
86215d5
Import localize from utils
nturinski Jul 1, 2024
26ebd81
Fix some of my goofiness
nturinski Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/tree/azure/grouping/GroupingItem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export class GroupingItem implements ResourceGroupsItem {
items.push(new GenericItem('', { description: subscription.name }));
}

for await (const resource of subscriptionGroupingMap.get(subscription) ?? []) {
await Promise.allSettled((subscriptionGroupingMap.get(subscription) ?? []).map(async (resource): Promise<void> => {
try {
const branchDataProvider = this.branchDataProviderFactory(resource);
const resourceItem = await branchDataProvider.getResourceItem(resource);
Expand All @@ -125,7 +125,8 @@ export class GroupingItem implements ResourceGroupsItem {
} catch (e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't have to be this PR but:

  • We should log this error.
  • And make sure it gets reported to telemetry.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oddly, this command doesn't pass in a context. It's a slightly bigger change to start pushing in a context everywhere for error telemetry, so I'll just log to output channel for now.

items.push(new InvalidAzureResourceItem(resource, e));
}
}
}));

return items;
}));

Expand Down
Loading