Use a promise.allSettle instead of a for loop that resolves one at a time #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -125,7 +125,8 @@ export class GroupingItem implements ResourceGroupsItem { | |||
| } catch (e) { | |||
There was a problem hiding this comment.
Doesn't have to be this PR but:
- We should log this error.
- And make sure it gets reported to telemetry.
There was a problem hiding this comment.
Oddly, this command doesn't pass in a context. It's a slightly bigger change to start pushing in a context everywhere for error telemetry, so I'll just log to output channel for now.
alexweininger
previously approved these changes
Jun 28, 2024
alexweininger
previously approved these changes
Jun 28, 2024
alexweininger
approved these changes
Jul 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We talked about this in stand up and I wanted to see if the performance boost was significant. Not surprisingly, it's an exponential performance boost, as in, the more resources you have, the better the improvement.
Functions has a weird bug right now that is hitting performance harder that I've fixed and will be putting up a PR for. It's making it take even longer, but it illustrates how much faster the promises are compared to the loop.
EDIT: left is the changes, right is the current release.