Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdf5] update to 1.14.5 #42616

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Mengna-Li
Copy link
Contributor

@Mengna-Li Mengna-Li commented Dec 10, 2024

Update to 1.14.5. For HDFGroup/hdf5#5157.

Add patch to fix build error: see HDFGroup/hdf5#5026.

CMake Error at CMakeFilters.cmake:109 (get_filename_component):
  get_filename_component unknown component
  D:/a/h5py/h5py/zlib-msvc-x64/build/native/lib_release/zlib.lib

All features are tested on the following triplets:

  • x64-windows
  • x64-windows-static
  • x86-windows

Usage tested on x64-windows.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Mengna-Li Mengna-Li added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Dec 10, 2024
@Mengna-Li Mengna-Li marked this pull request as ready for review December 11, 2024 01:35
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Dec 11, 2024
@@ -72,6 +73,7 @@ vcpkg_cmake_configure(
-DHDF_PACKAGE_NAMESPACE:STRING=hdf5::
-DHDF5_MSVC_NAMING_CONVENTION=OFF
-DALLOW_UNSUPPORTED=${ALLOW_UNSUPPORTED}
-DHDF5_ENABLE_SZIP_SUPPORT=OFF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by this change. I see that szip is a default feature for this port but we are explicitly turning it off? I'm assuming that HDF5_ENABLE_SZIP_SUPPORT controls the szip/libaec dependency.

But we are also patching the find package call here https://github.com/microsoft/vcpkg/pull/42616/files#diff-3d223a52df939f9e2e76c311e77a59b4ea9d4bbf89b112e7795399aef2641593R24 and we don't have an szip port. The szip feature depends on libaec port.

@JavierMatosD JavierMatosD marked this pull request as draft December 12, 2024 20:01
@dg0yt
Copy link
Contributor

dg0yt commented Dec 13, 2024

CMake Error at CMakeFilters.cmake:109 (get_filename_component):
  get_filename_component unknown component
  D:/a/h5py/h5py/zlib-msvc-x64/build/native/lib_release/zlib.lib

I didn't check the full picture, but I guess that in vpckg, this is from calling get_filename_component on ${ZLIB_LIBRARIES} which is not a single lib but a list debug .... optimized ....
And I'm afraid that ignoring this fact also spills into the pc files.

@MonicaLiu0311 MonicaLiu0311 removed the info:reviewed Pull Request changes follow basic guidelines label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants