-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hdf5] update to 1.14.5 #42616
base: master
Are you sure you want to change the base?
[hdf5] update to 1.14.5 #42616
Conversation
@@ -72,6 +73,7 @@ vcpkg_cmake_configure( | |||
-DHDF_PACKAGE_NAMESPACE:STRING=hdf5:: | |||
-DHDF5_MSVC_NAMING_CONVENTION=OFF | |||
-DALLOW_UNSUPPORTED=${ALLOW_UNSUPPORTED} | |||
-DHDF5_ENABLE_SZIP_SUPPORT=OFF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused by this change. I see that szip
is a default feature for this port but we are explicitly turning it off? I'm assuming that HDF5_ENABLE_SZIP_SUPPORT
controls the szip
/libaec
dependency.
But we are also patching the find package call here https://github.com/microsoft/vcpkg/pull/42616/files#diff-3d223a52df939f9e2e76c311e77a59b4ea9d4bbf89b112e7795399aef2641593R24 and we don't have an szip
port. The szip
feature depends on libaec
port.
I didn't check the full picture, but I guess that in vpckg, this is from calling get_filename_component on |
Update to 1.14.5. For HDFGroup/hdf5#5157.
Add patch to fix build error: see HDFGroup/hdf5#5026.
All features are tested on the following triplets:
Usage tested on
x64-windows
.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.