Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eigen3] [ignition-modularscripts] Fix installed pkgconfig files #11270

Merged
merged 3 commits into from
May 11, 2020

Conversation

traversaro
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    • This PR should not affected the supported or not supported triplets.
  • Does your PR follow the maintainer guide?

    • Yes

traversaro added 2 commits May 9, 2020 15:38
Now ignition-cmake also installs a C++ library, so
it is possible to remove code specific for CMake-only ports.
…ibraries

Use the new function vcpkg_fixup_pkgconfig to fix the installed .pc pkgconfig files
of the ignition libraries.

As ignition-fuel-tools1 depends on curl that has a broken pkg-config file, disable
installation of its pkg-config files.
@traversaro traversaro force-pushed the ignition-fixup-pkgconfig branch from dced5f5 to 67c6b55 Compare May 9, 2020 15:37
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label May 11, 2020
@strega-nil
Copy link
Contributor

Cool, LGTM! Thanks @traversaro :)

@strega-nil strega-nil merged commit 09b769b into microsoft:master May 11, 2020
@traversaro traversaro deleted the ignition-fixup-pkgconfig branch May 24, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants