Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Many ports: Add vcpkg_fixup_pkgconfig() #11087

Closed
Neumann-A opened this issue Apr 29, 2020 · 5 comments
Closed

[vcpkg] Many ports: Add vcpkg_fixup_pkgconfig() #11087

Neumann-A opened this issue Apr 29, 2020 · 5 comments
Assignees
@JackBoosY
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@Neumann-A
Copy link
Contributor

Neumann-A commented Apr 29, 2020 •
edited
Loading

Does somebody have a list of ports which install *.pc files?
Lets flood the team with PRs adding the new function call :P
@Neumann-A Neumann-A added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Apr 29, 2020
@traversaro traversaro mentioned this issue May 9, 2020
Merged
@traversaro
Copy link
Contributor

Related PR: #11270 .

@traversaro
Copy link
Contributor

Related issue: #10039 .

@traversaro traversaro mentioned this issue Jul 4, 2020
Merged
@strega-nil strega-nil removed their assignment Sep 3, 2020
@strega-nil strega-nil added category:port-bug The issue is with a library, which is something the port should already support and removed category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed labels Sep 3, 2020
@JackBoosY JackBoosY self-assigned this Nov 3, 2020
@okhowang
Copy link

okhowang commented May 8, 2021

Can vcpkg_fixup_pkgconfig() be called by vcpkg self, not in portfile.cmake.
It may resolve problem like Imported target "PkgConfig::libtiff-4" includes non-existent path oncely.
fixing all portfile is a large work.

@dg0yt
Copy link
Contributor

dg0yt commented May 9, 2021 •
edited
Loading

Does somebody have a list of ports which install *.pc files?

For each CI build, there is an artifact named "file list for ...". It contains a file named VCPKGDatabase.txt which can be grepped for lib/pkgconfig.
Now the difficulty is to find a recent successful build of all ports, for all triplets.
Ports which do not properly fix the prefix will be broken by #17205.

@PhoebeHui
Copy link
Contributor

Closing in favor of #20469.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@traversaro @okhowang @strega-nil @dg0yt @PhoebeHui @Neumann-A @JackBoosY