http-client-java, do not generate overload, when sync-method=none (#5736

) bug fix for Azure/autorest.java#3016 (comment)
microsoft · Jan 24, 2025 · e477a88 · e477a88
1 parent 5b49b5d
commit e477a88
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/...ain/java/com/microsoft/typespec/http/client/generator/core/mapper/ClientMethodMapper.java b/...ain/java/com/microsoft/typespec/http/client/generator/core/mapper/ClientMethodMapper.java
@@ -784,7 +784,9 @@ private static void createPageableClientMethods(Operation operation, boolean isP
             .groupedParameterRequired(false)
             .methodVisibility(methodVisibility);
 
-        methods.add(builder.build());
+        if (settings.getSyncMethods() != SyncMethodsGeneration.NONE) {
+            methods.add(builder.build());
+        }
 
         // Generate an overload with all parameters, optionally include context.
         builder.methodVisibility(visibilityFunction.methodVisibility(true, defaultOverloadType, true));
@@ -806,10 +808,14 @@ private static void createPageableClientMethods(Operation operation, boolean isP
             .groupedParameterRequired(false)
             .methodVisibility(visibilityFunction.methodVisibility(false, defaultOverloadType, false));
 
-        methods.add(builder.build());
+        if (settings.getSyncMethods() != SyncMethodsGeneration.NONE) {
+            // generate the overload, if "sync-methods != NONE"
 
-        // overload for versioning
-        createOverloadForVersioning(isProtocolMethod, methods, builder, parameters);
+            methods.add(builder.build());
+
+            // overload for versioning
+            createOverloadForVersioning(isProtocolMethod, methods, builder, parameters);
+        }
 
         if (generateClientMethodWithOnlyRequiredParameters) {
             methods.add(builder.onlyRequiredParameters(true)