Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eclipse language server, handle directory corruption #3016

Merged
merged 10 commits into from
Jan 24, 2025

Conversation

XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Jan 21, 2025

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require a release of azure-autorest-customization lib?

Just checking, we may not need to release now, even if it requires.

@XiaofeiCao
Copy link
Contributor Author

XiaofeiCao commented Jan 21, 2025

Does this require a release of azure-autorest-customization lib?

Just checking, we may not need to release now, even if it requires.

Probably not?
In autorest.java, we used maven-shade-plugin which I assume would pack all dependent modules(including customization-base) into released package.
In typespec-java/http-client-java, seems we don't depend on azure-autorest-customization lib.

@weidongxu-microsoft
Copy link
Member

Probably not? In autorest.java, we used maven-shade-plugin which I assume would pack all dependent modules(including customization-base) into released package. In typespec-java/http-client-java, seems we don't depend on azure-autorest-customization lib.

Yeah, if http-client-java fixed after this change, it won't need the azure lib.

@XiaofeiCao XiaofeiCao marked this pull request as ready for review January 24, 2025 09:23
@XiaofeiCao XiaofeiCao merged commit 1ee754e into Azure:main Jan 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants