Fix issue with operation parameter versioning (#2691)

Fixes #2688.
microsoft · Nov 22, 2023 · b3075f0 · b3075f0
1 parent cc03604
commit b3075f0
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 64 deletions.
diff --git a/common/changes/@typespec/versioning/versioning-OpParams_2023-11-22-18-08.json b/common/changes/@typespec/versioning/versioning-OpParams_2023-11-22-18-08.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@typespec/versioning",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@typespec/versioning"
+}
diff --git a/packages/versioning/src/validate.ts b/packages/versioning/src/validate.ts
@@ -532,24 +532,6 @@ function validateOperationParameter(
       return;
     }
   }
-
-  if (paramAvailability !== undefined) {
-    validateAvailabilityForContains(
-      program,
-      operationAvailability,
-      paramAvailability,
-      operation,
-      parameter
-    );
-  } else if (paramTypeAvailability !== undefined) {
-    validateAvailabilityForRef(
-      program,
-      operationAvailability,
-      paramTypeAvailability,
-      operation,
-      parameter.type
-    );
-  }
 }
 
 /**

diff --git a/packages/versioning/test/incompatible-versioning.test.ts b/packages/versioning/test/incompatible-versioning.test.ts
@@ -146,52 +146,6 @@ describe("versioning: validate incompatible references", () => {
       });
     });
 
-    it("emit diagnostic when when op was added before parameter type", async () => {
-      const diagnostics = await runner.diagnose(`
-        @added(Versions.v2)
-        model Foo {}
-
-        @added(Versions.v1)
-        op test(param: Foo): void;
-      `);
-      expectDiagnostics(diagnostics, {
-        code: "@typespec/versioning/incompatible-versioned-reference",
-        message:
-          "'TestService.test' was added in version 'v1' but referencing type 'TestService.Foo' added in version 'v2'.",
-      });
-    });
-
-    it("emit diagnostic when op based on a template was added before parameter type", async () => {
-      const diagnostics = await runner.diagnose(`
-        @added(Versions.v2)
-        model Foo {}
-
-        op Template<T>(param: T): void;
-
-        @added(Versions.v1)
-        op test is Template<Foo>;
-      `);
-      expectDiagnostics(diagnostics, {
-        code: "@typespec/versioning/incompatible-versioned-reference",
-        message:
-          "'TestService.test' was added in version 'v1' but referencing type 'TestService.Foo' added in version 'v2'.",
-      });
-    });
-
-    it("emit diagnostic when when parameter was added before op", async () => {
-      const diagnostics = await runner.diagnose(`
-        model Foo {}
-
-        @added(Versions.v2)
-        op test(@added(Versions.v1) param: Foo): void;
-      `);
-      expectDiagnostics(diagnostics, {
-        code: "@typespec/versioning/incompatible-versioned-reference",
-        message:
-          "'TestService.test' was added in version 'v2' but contains type 'TestService.(anonymous model).param' added in version 'v1'.",
-      });
-    });
-
     it("emit diagnostic when type changed to types that don't exist", async () => {
       const diagnostics = await runner.diagnose(`
       @added(Versions.v3)  

diff --git a/packages/versioning/test/versioning.test.ts b/packages/versioning/test/versioning.test.ts
@@ -912,6 +912,34 @@ describe("versioning: logic", () => {
       w2.operations.get("create")?.parameters.properties.size === 2;
     });
 
+    it("can share a model reference between operations with different versions", async () => {
+      const code = `
+        @test("MyService")
+        @versioned(Versions)
+        namespace MyService;
+
+        enum Versions { v1, v2, v3 };
+        
+        model Foo {
+          prop: string;
+        }
+        
+        model Parameters {
+          name: string;
+        
+          @added(Versions.v2)
+          age: Foo;
+        }
+        
+        @added(Versions.v1)
+        op oldOp(...Parameters): void;
+        
+        @added(Versions.v3)
+        op newOp(...Parameters): void;
+        `;
+      ok(await runner.compile(code));
+    });
+
     it("can be removed", async () => {
       const {
         projections: [v1, v2],