-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
align command palette prefix > to left when visible #8279
align command palette prefix > to left when visible #8279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what the heck
Testing this out, it definitely works, but like, why?
(That's a rhetorical "why" - I don't really need an explanation)
@zadjii-msft It may be possible that the solution could be bit out of normal as I have zero working experience in building Windows applications, nuget, XAML, C++ codebase, PowerShell or Visual Studio project but since I rely heavily on Windows Terminal (and WSL2) for Ruby on Rails and JavaScript projects I really appreciate you folks' effort on making Windows Terminal better everyday. So, I thought of contributing as much as I can even though I don't have previous working knowledge in these tech stack. So coming back to the initial point, I arrived at the solution mostly by On top of all of this, it would be my first ever open source contribution if it makes to |
You did a great job with this, I'll be honest. I don't think I would have intuitively tried the HorizontalAlignment=Left thing, which definitely seems to work here. I don't have all that much XAML experience though, so I guess I don't know how that interacts with the width of the control. So props to you for figuring that out 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised that this was the problem. Good catch!
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Fixes the clear button to clear the typed command not clickable in the command palette. - From the primary investigation it looked like the `TextBlock` element introduced in #7935 was somehow blocking (appearing on top of) the clear button. - It was also blocking the command palette input field from being able to access which was preventing the text in the input field from being selected and the cursor would still show as `pointer` cursor instead of a `text selection` cursor - Adding `HorizontalAlignment="Left"` property to the above-mentioned `TextBlock` element fixed the issue. ## Validation Steps Performed - Created the Dev build for `x64` in Visual Studio and verified the functionality manually. Closes #8220 (cherry picked from commit a8f3f58)
🎉 Handy links: |
Fixes the clear button to clear the typed command not clickable in the
command palette.
TextBlock
elementintroduced in Swap the command palette modes for the prefix
>
#7935 was somehow blocking (appearing on top of) theclear button.
to access which was preventing the text in the input field from being
selected and the cursor would still show as
pointer
cursor insteadof a
text selection
cursorHorizontalAlignment="Left"
property to the above-mentionedTextBlock
element fixed the issue.Validation Steps Performed
x64
in Visual Studio and verified thefunctionality manually.
Closes #8220