Swap the command palette modes for the prefix >
#7935
Conversation
ghost
added
Area-UserInterface
| @@ -396,6 +397,9 @@ | |||
| <data name="TabSwitcher_NoMatchesText" xml:space="preserve"> | |||
| <value>No matching tab name</value> | |||
| </data> | |||
| <data name="CmdPalActionPrompt" xml:space="preserve"> | |||
| <value>Type a command name...</value> | |||
There was a problem hiding this comment.
Little sad that we need to force a re-localization for this key change
There was a problem hiding this comment.
Since we are already not using a uid for the search box, can we just keep the key names and juggle them different at runtime?
There was a problem hiding this comment.
I dont see why not. I think this was originally from the first way I tried implementing this, which was a bust.
Does the localization happen multiple times per release? I figured it happened once per release, right before we released
There was a problem hiding this comment.
We've got a scheduled job that submits strings at 6pm pacific every day 😄
There was a problem hiding this comment.
Be sure to coordinate with @cinnamon-msft on updating the docs. I think the schema doesn't need updating though, so that's good.
DHowett
changed the title
>>
|
🎉 Handy links: |
ghost
mentioned this pull request
Fixes the clear button to clear the typed command not clickable in the command palette. - From the primary investigation it looked like the `TextBlock` element introduced in #7935 was somehow blocking (appearing on top of) the clear button. - It was also blocking the command palette input field from being able to access which was preventing the text in the input field from being selected and the cursor would still show as `pointer` cursor instead of a `text selection` cursor - Adding `HorizontalAlignment="Left"` property to the above-mentioned `TextBlock` element fixed the issue. ## Validation Steps Performed - Created the Dev build for `x64` in Visual Studio and verified the functionality manually. Closes #8220
Fixes the clear button to clear the typed command not clickable in the command palette. - From the primary investigation it looked like the `TextBlock` element introduced in #7935 was somehow blocking (appearing on top of) the clear button. - It was also blocking the command palette input field from being able to access which was preventing the text in the input field from being selected and the cursor would still show as `pointer` cursor instead of a `text selection` cursor - Adding `HorizontalAlignment="Left"` property to the above-mentioned `TextBlock` element fixed the issue. ## Validation Steps Performed - Created the Dev build for `x64` in Visual Studio and verified the functionality manually. Closes #8220 (cherry picked from commit a8f3f58)
Summary of the Pull Request
VsCode uses
>as its "prefix" for the equivalent of their "action mode". This PR aligns the Terminal with their logic here.PR Checklist
Detailed Description of the Pull Request / Additional comments
We have to be tricky - if we use the
>in the actual input as the indicator for action mode, we can't display any placeholder text in the input to tell users to type a command. This wasn't an issue for the commandline mode previously, because we'd stick the "prompt" in the "no matches text" space. However, we can't do that for action mode. Instead, we'll stick a floating text block over the input box, and when the user's in action mode, we'll manually place a>into that space. When the user backspaces the>, we'll remove it from that block, and switch into commandline mode.Validation Steps Performed
Played with the cmdpal in lots of different modes, this finally feels good