Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace everything in TerminalSettings with GETSET_PROPERTY #6110

Merged
2 commits merged into from
May 27, 2020
Merged

Replace everything in TerminalSettings with GETSET_PROPERTY #6110

2 commits merged into from
May 27, 2020

Conversation

zadjii-msft
Copy link
Member

This is mostly a codehealth thing - we made these handy macros for just defining basic { get; set; } properties, but we never used them in TerminalSettings, because that file was written before the macros were.

This cleans up that class.

  • I work here.

DHowett
DHowett approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship the HECC out of this

@zadjii-msft zadjii-msft added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels May 21, 2020
@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label May 21, 2020
@ghost ghost requested review from miniksa, carlos-zamora and leonMSFT May 21, 2020 22:06
@zadjii-msft zadjii-msft mentioned this pull request May 27, 2020
Merged
5 tasks
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 27, 2020
@ghost
Copy link

ghost commented May 27, 2020

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit e7c22fb into master May 27, 2020
@ghost ghost deleted the dev/migrie/f/just-delete-it-all branch May 27, 2020 21:46
jelster pushed a commit to jelster/terminal that referenced this pull request May 28, 2020
@zadjii-msft @jelster
Replace everything in TerminalSettings with GETSET_PROPERTY (micr…
e14b1e0 
…osoft#6110)

This is mostly a codehealth thing - we made these handy macros for just defining basic `{ get; set; }` properties, but we never used them in TerminalSettings, because that file was written before the macros were.

This cleans up that class.

* [x] I work here.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett DHowett DHowett approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zadjii-msft @DHowett @carlos-zamora