Skip to content

Commit

Permalink
Replace everything in TerminalSettings with GETSET_PROPERTY (#6110)
Browse files Browse the repository at this point in the history 
This is mostly a codehealth thing - we made these handy macros for just defining basic `{ get; set; }` properties, but we never used them in TerminalSettings, because that file was written before the macros were.

This cleans up that class.

* [x] I work here.
  • Loading branch information
@zadjii-msft
zadjii-msft authored May 27, 2020
1 parent 1ea0889 commit e7c22fb
Show file tree
Hide file tree
Showing 3 changed files with 69 additions and 514 deletions.
Loading

1 comment on commit e7c22fb

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New misspellings found, please review:

  • IStorage
To accept these changes, run the following commands 
remove_obsolete_words=$(mktemp)
echo '#!/usr/bin/perl -ni
my $re=join "|", qw('"
AAD
abcd
abe
abec
acb
afae
afceeeaa
baac
bbd
bca
bcb
bcc
bda
bfb
bitfield
caa
carlos
cbb
dcf
ddb
dfa
eba
ebce
EBFB
ECFB
eeb
eee
Emoji
Emojis
fbb
fbd
FBE
fcc
fd
fdb
fdd
ffc
HREF
memcpying
OUTPATHROOT
storageitems
textblock
usr
vpack
zamora
"');
next if /^($re)(?:$| .*)/;
print;' > $remove_obsolete_words
chmod +x $remove_obsolete_words
for file in .github/actions/spell-check/whitelist/alphabet.txt .github/actions/spell-check/whitelist/web.txt .github/actions/spell-check/whitelist/whitelist.txt; do $remove_obsolete_words $file; done
rm $remove_obsolete_words
(
echo "
ABE
EEB
FDD
IStorage
"
) | sort -u -f | perl -ne 'next unless /./; print' > new_whitelist.txt && mv new_whitelist.txt '.github/actions/spell-check/whitelist/e7c22fbadb681c489d7660fc3749348c0c1d83fd.txt'
✏️ Contributor please read this
  • If the items listed above are names, please add them to .github/actions/spell-check/dictionary/names.txt.
  • If they're APIs, you can add them to a file in .github/actions/spell-check/dictionary/.
  • If they're just things you're using, please add them to an appropriate file in .github/actions/spell-check/whitelist/.
  • If you need to use a specific token in one place and it shouldn't generally be used, you can
    add an item in an appropriate file in .github/actions/spell-check/patterns/.

See the README.md in each directory for more information.

⚠️ Reviewers

At present, the action that triggered this message will not show its ❌ in this PR unless the branch is within this repository.
Thus, you should make sure that this comment has been addressed before encouraging the merge bot to merge this PR.

Please sign in to comment.