Manually close tabs when they're closed while dragging them #5883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary of the Pull Request When we're dragging the tab around, if you execute a `ClosePane`/`CloseTab`, then we should make sure to actually activate a new tab, so that focus doesn't just fall into the void. ## References * This is almost exactly #5799, but with rearranging tabs ## PR Checklist * [x] Closes #5559 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments We suppress `_OnTabItemsChanged` events during a rearrange, so if a tab is closed while we're rearranging tabs, the we don't fire the `SelectionChanged` event that we usually do during a close that would select the new tab. ## Validation Steps Performed * Tested manually - Confirmed that tragging a tab out, closing it, then dragging it back in does nothing.
ghost
added
Area-Input
carlos-zamora
approved these changes
May 13, 2020
DHowett-MSFT
approved these changes
May 13, 2020
Shockingly, yea. I bet the whole drag-drop is managed by something like |
DHowett-MSFT
added
the
AutoMerge
|
Hello @DHowett-MSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
jelster
pushed a commit
to jelster/terminal
that referenced
this pull request
May 28, 2020
…t#5883) ## Summary of the Pull Request When we're dragging the tab around, if you execute a `ClosePane`/`CloseTab`, then we should make sure to actually activate a new tab, so that focus doesn't just fall into the void. ## References * This is almost exactly microsoft#5799, but with rearranging tabs ## PR Checklist * [x] Closes microsoft#5559 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments We suppress `_OnTabItemsChanged` events during a rearrange, so if a tab is closed while we're rearranging tabs, the we don't fire the `SelectionChanged` event that we usually do during a close that would select the new tab. ## Validation Steps Performed * Tested manually - Confirmed that tragging a tab out, closing it, then dragging it back in does nothing.
|
🎉 Handy links: |
ghost
mentioned this pull request
DHowett
pushed a commit
that referenced
this pull request
Jun 24, 2020
## Summary of the Pull Request When we're dragging the tab around, if you execute a `ClosePane`/`CloseTab`, then we should make sure to actually activate a new tab, so that focus doesn't just fall into the void. ## References * This is almost exactly #5799, but with rearranging tabs ## PR Checklist * [x] Closes #5559 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments We suppress `_OnTabItemsChanged` events during a rearrange, so if a tab is closed while we're rearranging tabs, the we don't fire the `SelectionChanged` event that we usually do during a close that would select the new tab. ## Validation Steps Performed * Tested manually - Confirmed that tragging a tab out, closing it, then dragging it back in does nothing. (cherry picked from commit 1422714)
DHowett
pushed a commit
that referenced
this pull request
Jun 24, 2020
## Summary of the Pull Request When we're dragging the tab around, if you execute a `ClosePane`/`CloseTab`, then we should make sure to actually activate a new tab, so that focus doesn't just fall into the void. ## References * This is almost exactly #5799, but with rearranging tabs ## PR Checklist * [x] Closes #5559 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments We suppress `_OnTabItemsChanged` events during a rearrange, so if a tab is closed while we're rearranging tabs, the we don't fire the `SelectionChanged` event that we usually do during a close that would select the new tab. ## Validation Steps Performed * Tested manually - Confirmed that tragging a tab out, closing it, then dragging it back in does nothing. (cherry picked from commit 1422714)
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When we're dragging the tab around, if you execute a
ClosePane/CloseTab, then we should make sure to actually activate a new tab, so that focus doesn't just fall into the void.References
PR Checklist
Detailed Description of the Pull Request / Additional comments
We suppress
_OnTabItemsChangedevents during a rearrange, so if a tab is closed while we're rearranging tabs, the we don't fire theSelectionChangedevent that we usually do during a close that would select the new tab.Validation Steps Performed