Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Terminal blocks user input after a tab is removed #5559

Closed
AVDAIN opened this issue Apr 25, 2020 · 16 comments · Fixed by #5883
Closed

Windows Terminal blocks user input after a tab is removed #5559

AVDAIN opened this issue Apr 25, 2020 · 16 comments · Fixed by #5883
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.x

Comments

@AVDAIN
Copy link

AVDAIN commented Apr 25, 2020 •
edited
Loading

Environment

Windows build number: 10.0.18363.815
Windows Terminal version (if applicable): 0.11.1121.0

Any other software?

Steps to reproduce

  • Start Windows Terminal
  • Open a new Windows PowerShell tab
  • Now drag the tab to a location without releasing the tab
  • Now close the tab with this key combination Ctrl + Shift + W
  • Now try to make an input in the command line on the first tab, or try a key combination.

Expected behavior

  • Windows PowerShell should allow input.
  • Windows Terminal should allow keyboard input after trying to create a new tab with the key combination Ctrl + Shift + T.

Actual behavior

  • Windows PowerShell does not allow input.
  • Windows Terminal does not allow keyboard input after you try to create a new tab with the key combination Ctrl + Shift + T.

ezgif-7-9b0200dbcf4a
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 25, 2020
@AVDAIN AVDAIN changed the title Windows PowerShell blocks input after a tab is removed Windows Terminal blocks input after a tab is removed Apr 25, 2020
@Sandra2001

This comment has been minimized.

Sign in to view
@Sandra2001

This comment has been minimized.

Sign in to view
@AVDAIN

This comment has been minimized.

Sign in to view
@DHowett-MSFT
Copy link
Contributor

If you click inside the terminal, does it start responding again?

Do you see the Windows “this program is not responding” message?

@AVDAIN
Copy link
Author

AVDAIN commented Apr 26, 2020 •
edited
Loading

@DHowett

  1. No, the application does not react when clicked in the terminal.
  2. No, this message "this program is not responding" is not displayed.

@AVDAIN
Copy link
Author

AVDAIN commented Apr 26, 2020

@DHowett The application reacts first when a new tab is created by clicking the "+" button.
The application also does not react to key combinations as described above.

@zadjii-msft
Copy link
Member

huh

@zadjii-msft zadjii-msft added Area-Input Related to input processing (key presses, mouse, etc.) Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Apr 27, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 27, 2020
@zadjii-msft zadjii-msft added this to the Terminal v1.x milestone Apr 27, 2020
@AVDAIN AVDAIN changed the title Windows Terminal blocks input after a tab is removed Windows Terminal blocks user input after a tab is removed Apr 27, 2020
@DHowett-MSFT
Copy link
Contributor

@IamAIQ please stop posting the same comment on all of our issues. If you would like to subscribe, please click the "Subscribe" button. If you would like to add your support, please click the ":+1:" button.

@DHowett-MSFT DHowett-MSFT added Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 28, 2020
@zadjii-msft zadjii-msft removed the Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. label Apr 29, 2020
@DHowett-MSFT DHowett-MSFT mentioned this issue May 7, 2020
Closed
@zadjii-msft
Copy link
Member

zadjii-msft commented May 8, 2020 •
edited
Loading

This might have gotten better with #5799/#5809 - if it didn't, then this will certainly be a similar class of issue.

EDIT: No, it didn't, but I bet this is because of the if (!dragging) check we do when the tab selection changes.

@zadjii-msft zadjii-msft added Priority-3 A description (P3) and removed Priority-2 A description (P2) labels May 8, 2020
@DHowett-MSFT
Copy link
Contributor

Almost certainly. Thanks for investigating!

@AVDAIN
Copy link
Author

AVDAIN commented May 11, 2020

@DHowett-MSFT I have added a GIF to better understand the problem.

@DHowett-MSFT
Copy link
Contributor

Thanks.

@AVDAIN
Copy link
Author

AVDAIN commented May 11, 2020

@DHowett-MSFT You're welcome. :)

@DHowett-MSFT DHowett-MSFT mentioned this issue May 11, 2020
Closed
@EugeneLockett
Copy link

Now, do I know who found this problem. DHowett
Thanks for the help

zadjii-msft added a commit that referenced this issue May 13, 2020
@zadjii-msft
Manually close tabs when they're closed while dragging them
7cde53a 
  ## Summary of the Pull Request

  When we're dragging the tab around, if you execute a `ClosePane`/`CloseTab`, then we should make sure to actually activate a new tab, so that focus doesn't just fall into the void.

  ## References

  * This is almost exactly #5799, but with rearranging tabs

  ## PR Checklist
  * [x] Closes #5559
  * [x] I work here
  * [ ] Tests added/passed
  * [n/a] Requires documentation to be updated

  ## Detailed Description of the Pull Request / Additional comments
  We suppress `_OnTabItemsChanged` events during a rearrange, so if a tab is closed while we're rearranging tabs, the we don't fire the `SelectionChanged` event that we usually do during a close that would select the new tab.

  ## Validation Steps Performed
  * Tested manually
    - Confirmed that tragging a tab out, closing it, then dragging it back in does nothing.
@zadjii-msft zadjii-msft mentioned this issue May 13, 2020
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label May 13, 2020
@ghost ghost closed this as completed in #5883 May 14, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels May 14, 2020
ghost pushed a commit that referenced this issue May 14, 2020
@zadjii-msft
Manually close tabs when they're closed while dragging them (#5883)
1422714 
## Summary of the Pull Request

When we're dragging the tab around, if you execute a `ClosePane`/`CloseTab`, then we should make sure to actually activate a new tab, so that focus doesn't just fall into the void.

## References

* This is almost exactly #5799, but with rearranging tabs

## PR Checklist
* [x] Closes #5559
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments
We suppress `_OnTabItemsChanged` events during a rearrange, so if a tab is closed while we're rearranging tabs, the we don't fire the `SelectionChanged` event that we usually do during a close that would select the new tab.

## Validation Steps Performed
* Tested manually
  - Confirmed that tragging a tab out, closing it, then dragging it back in does nothing.
jelster pushed a commit to jelster/terminal that referenced this issue May 28, 2020
@zadjii-msft @jelster
Manually close tabs when they're closed while dragging them (microsof…
8179678 
…t#5883)

## Summary of the Pull Request

When we're dragging the tab around, if you execute a `ClosePane`/`CloseTab`, then we should make sure to actually activate a new tab, so that focus doesn't just fall into the void.

## References

* This is almost exactly microsoft#5799, but with rearranging tabs

## PR Checklist
* [x] Closes microsoft#5559
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments
We suppress `_OnTabItemsChanged` events during a rearrange, so if a tab is closed while we're rearranging tabs, the we don't fire the `SelectionChanged` event that we usually do during a close that would select the new tab.

## Validation Steps Performed
* Tested manually
  - Confirmed that tragging a tab out, closing it, then dragging it back in does nothing.
@ghost
Copy link

ghost commented Jun 18, 2020

🎉This issue was addressed in #5883, which has now been successfully released as Windows Terminal Preview v1.1.1671.0.:tada:

Handy links:

DHowett pushed a commit that referenced this issue Jun 24, 2020
@zadjii-msft @DHowett
Manually close tabs when they're closed while dragging them (#5883)
772b538 
## Summary of the Pull Request

When we're dragging the tab around, if you execute a `ClosePane`/`CloseTab`, then we should make sure to actually activate a new tab, so that focus doesn't just fall into the void.

## References

* This is almost exactly #5799, but with rearranging tabs

## PR Checklist
* [x] Closes #5559
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments
We suppress `_OnTabItemsChanged` events during a rearrange, so if a tab is closed while we're rearranging tabs, the we don't fire the `SelectionChanged` event that we usually do during a close that would select the new tab.

## Validation Steps Performed
* Tested manually
  - Confirmed that tragging a tab out, closing it, then dragging it back in does nothing.

(cherry picked from commit 1422714)
DHowett pushed a commit that referenced this issue Jun 24, 2020
@zadjii-msft @DHowett
Manually close tabs when they're closed while dragging them (#5883)
a9adc93 
## Summary of the Pull Request

When we're dragging the tab around, if you execute a `ClosePane`/`CloseTab`, then we should make sure to actually activate a new tab, so that focus doesn't just fall into the void.

## References

* This is almost exactly #5799, but with rearranging tabs

## PR Checklist
* [x] Closes #5559
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments
We suppress `_OnTabItemsChanged` events during a rearrange, so if a tab is closed while we're rearranging tabs, the we don't fire the `SelectionChanged` event that we usually do during a close that would select the new tab.

## Validation Steps Performed
* Tested manually
  - Confirmed that tragging a tab out, closing it, then dragging it back in does nothing.

(cherry picked from commit 1422714)
@ghost
Copy link

ghost commented Jun 30, 2020

🎉This issue was addressed in #5883, which has now been successfully released as Windows Terminal v1.0.1811.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.x
Development

Successfully merging a pull request may close this issue.

Manually close tabs when they're closed while dragging them microsoft/terminal
6 participants
@DHowett-MSFT @zadjii-msft @AVDAIN @Sandra2001 @EugeneLockett and others