Teach TerminalPage to handle exceptions that happen during paste #5856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terminal should not try to join the choir invisible when the clipboard API straight-up horks it. Fixes #4906.
ghost
added
Area-UserInterface
|
The exception was coming out of |
carlos-zamora
approved these changes
May 12, 2020
zadjii-msft
approved these changes
May 12, 2020
DHowett-MSFT
pushed a commit
that referenced
this pull request
May 12, 2020
Terminal should try not to join the choir invisible when the clipboard API straight up horks it. This accounts for ~3% of the crashes seen in 1.0RC1 and ~1% of the crashes seen all-up in the last 14 days. ## Repro (prior to this commit) Set `"copyOnSelect": true`. Copy something small. Hold down <kbd>Ctrl+Shift+V</kbd> Double-click like your life depends on it. Double-click like you're playing cookie clicker again. 2013 called, it wants its cookies back. Fixes #4906. (cherry picked from commit a99c812)
|
🎉 Handy links: |
ghost
mentioned this pull request
jelster
pushed a commit
to jelster/terminal
that referenced
this pull request
May 28, 2020
…rosoft#5856) Terminal should try not to join the choir invisible when the clipboard API straight up horks it. This accounts for ~3% of the crashes seen in 1.0RC1 and ~1% of the crashes seen all-up in the last 14 days. ## Repro (prior to this commit) Set `"copyOnSelect": true`. Copy something small. Hold down <kbd>Ctrl+Shift+V</kbd> Double-click like your life depends on it. Double-click like you're playing cookie clicker again. 2013 called, it wants its cookies back. Fixes microsoft#4906.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Terminal should try not to join the choir invisible when the clipboard
API straight up horks it.
This accounts for ~3% of the crashes seen in 1.0RC1 and ~1% of the crashes
seen all-up in the last 14 days.
Fixes #4906.
PR Checklist
Validation Steps Performed
Found out a surefire way to repro it!
"copyOnSelect": trueCopy something small.
Hold down Ctrl+Shift+V
Double-click like your life depends on it. Double-click like you're
playing cookie clicker again. 2013 called, it wants its cookies back.