Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in Windows Terminal when copying text #4906

Closed
Treit opened this issue Mar 13, 2020 · 4 comments · Fixed by #5856
Closed

Crash in Windows Terminal when copying text #4906

Treit opened this issue Mar 13, 2020 · 4 comments · Fixed by #5856
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Milestone
Terminal v1.x

Comments

@Treit
Copy link

Treit commented Mar 13, 2020 •
edited
Loading

While right-clicking on some selected text to copy it to the clipboard, WindowsTerminal.exe crashed.

This was with version 0.9.433.0.

WindowsTerminal10.txt

I have attached the debugger output with more details. The call stack at the time of the crash was:

TerminalApp!winrt::throw_hresult+0x1de
TerminalApp!winrt::impl::delegate<winrt::Windows::Foundation::AsyncOperationCompletedHandler<enum winrt::Windows::UI::Xaml::Controls::ContentDialogResult>,<lambda_33260d216710055959e11cc27647c577> >::Invoke+0x7d
windows_applicationmodel_datatransfer!Windows::Internal::AsyncBaseFTM<Windows::Foundation::IAsyncOperationCompletedHandler<HSTRING__ *>,1,Microsoft::WRL::AsyncOptions<-1,0,&GUID_CAUSALITY_WINDOWS_PLATFORM_ID,2> >::FireCompletion+0x219
windows_applicationmodel_datatransfer!Windows::Internal::AsyncOperation<Windows::Foundation::IAsyncOperation<HSTRING__ *>,Windows::Foundation::IAsyncOperationCompletedHandler<HSTRING__ *>,Windows::Internal::CHSTRINGResult,Windows::Internal::ComTaskPoolHandler,Windows::Internal::INilDelegate,Microsoft::WRL::AsyncOptions<-1,0,&GUID_CAUSALITY_WINDOWS_PLATFORM_ID,2> >::_AfterExecute+0xaf
windows_applicationmodel_datatransfer!Windows::Internal::AsyncOperation<Windows::Foundation::IAsyncOperation<HSTRING__ *>,Windows::Foundation::IAsyncOperationCompletedHandler<HSTRING__ *>,Windows::Internal::CHSTRINGResult,Windows::Internal::ComTaskPoolHandler,Windows::Internal::INilDelegate,Microsoft::WRL::AsyncOptions<-1,0,&GUID_CAUSALITY_WINDOWS_PLATFORM_ID,2> >::Run+0xe6
SHCore!WorkThreadManager::CThread::ThreadProc+0x2ec
SHCore!WorkThreadManager::CThread::s_ExecuteThreadProc+0x18
SHCore!<lambda_9844335fc14345151eefcc3593dd6895>::<lambda_invoker_cdecl>+0x11
kernel32!BaseThreadInitThunk+0x14
ntdll!RtlUserThreadStart+0x21```
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 13, 2020
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Severity-Crash Crashes are real bad news. Product-Terminal The new Windows Terminal. labels Mar 13, 2020
@AutisticShark
Copy link

I just run into this issue too, but not on the shell page itself. When I try to copy a selected string from 'About' sub-menu by right-clicking then choose 'Copy', Windows Terminal crashes. Version is the latest 0.10.761.0.

@zadjii-msft
Copy link
Member

@toxic-cat that issue is actually totally different, and being tracked over in #4260

@AutisticShark
Copy link

@zadjii-msft Thank you for mention that.

@DHowett-MSFT DHowett-MSFT added Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Priority-2 A description (P2) Area-UserInterface Issues pertaining to the user interface of the Console or Terminal and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 19, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 19, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.x milestone Mar 19, 2020
DHowett-MSFT pushed a commit that referenced this issue May 12, 2020
@DHowett
Stop eating it on exceptions during paste
42848cc 
Terminal should not try to join the choir invisible when the clipboard
API straight-up horks it.

Fixes #4906.
@DHowett-MSFT DHowett-MSFT mentioned this issue May 12, 2020
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label May 12, 2020
DHowett-MSFT pushed a commit that referenced this issue May 12, 2020
@DHowett
Teach TerminalPage to handle exceptions that happen during paste (#5856)
a99c812 
Terminal should try not to join the choir invisible when the clipboard
API straight up horks it.

This accounts for ~3% of the crashes seen in 1.0RC1 and ~1% of the
crashes seen all-up in the last 14 days.

## Repro (prior to this commit)
Set `"copyOnSelect": true`.

Copy something small.

Hold down <kbd>Ctrl+Shift+V</kbd>

Double-click like your life depends on it. Double-click like you're
playing cookie clicker again. 2013 called, it wants its cookies back.

Fixes #4906.
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels May 12, 2020
DHowett-MSFT pushed a commit that referenced this issue May 12, 2020
@DHowett
Teach TerminalPage to handle exceptions that happen during paste (#5856)
c31c857 
Terminal should try not to join the choir invisible when the clipboard
API straight up horks it.

This accounts for ~3% of the crashes seen in 1.0RC1 and ~1% of the
crashes seen all-up in the last 14 days.

## Repro (prior to this commit)
Set `"copyOnSelect": true`.

Copy something small.

Hold down <kbd>Ctrl+Shift+V</kbd>

Double-click like your life depends on it. Double-click like you're
playing cookie clicker again. 2013 called, it wants its cookies back.

Fixes #4906.

(cherry picked from commit a99c812)
@ghost
Copy link

ghost commented May 13, 2020

🎉This issue was addressed in #5856, which has now been successfully released as Windows Terminal Release Candidate v0.11.1333.0 (1.0rc2).:tada:

Handy links:

jelster pushed a commit to jelster/terminal that referenced this issue May 28, 2020
@DHowett @jelster
Teach TerminalPage to handle exceptions that happen during paste (mic…
60485bb 
…rosoft#5856)

Terminal should try not to join the choir invisible when the clipboard
API straight up horks it.

This accounts for ~3% of the crashes seen in 1.0RC1 and ~1% of the
crashes seen all-up in the last 14 days.

## Repro (prior to this commit)
Set `"copyOnSelect": true`.

Copy something small.

Hold down <kbd>Ctrl+Shift+V</kbd>

Double-click like your life depends on it. Double-click like you're
playing cookie clicker again. 2013 called, it wants its cookies back.

Fixes microsoft#4906.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v1.x
Development

Successfully merging a pull request may close this issue.

Teach TerminalPage to handle exceptions that happen during paste microsoft/terminal
4 participants
@Treit @DHowett-MSFT @AutisticShark @zadjii-msft