-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a dark titlebar when we've requested dark theme #14536
Conversation
…s really matters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worry about white flash
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@msftbot merge this in 5 minutes |
Hello @carlos-zamora! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
@msftbot forget everything I just told you |
Hello @DHowett! Because you've told me to reset the custom auto-merge settings, I'll use the configured settings for this repository when I'm merging this pull request. |
(It might seem weird, but this is what i intended. 0 minutes instead of 5!) |
🎉 Handy links: |
This applies to
"showTabsInTitlebar": false,
. We literally never set that for theIslandWindow
before, only ever the NCIW.Closes #11589
For a dramatic example - here's the IW with mica enabled, in dark mode:
Theme json: