Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cause the title-bar to use the dark theme when tabs are disabled. #11589

Closed
RokeJulianLockhart opened this issue Oct 23, 2021 · 2 comments · Fixed by #14536
Closed

Cause the title-bar to use the dark theme when tabs are disabled. #11589

RokeJulianLockhart opened this issue Oct 23, 2021 · 2 comments · Fixed by #14536
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Backlog

Comments

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Oct 23, 2021 •
edited
Loading

Description of the new feature/enhancement

The current appearance of the title-bar of Windows Terminal Preview is:

image

Consequently, please cause the title-bar to use the dark theme:

image

...because this would improve visual consistency, and allow the terminal to not cause ocular strain during observation of it from within darkness.
@RokeJulianLockhart RokeJulianLockhart added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 23, 2021
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 23, 2021
@RokeJulianLockhart RokeJulianLockhart changed the title Please cause the title-bar to use the dark theme when tabs are disabled. Please do cause the title-bar to use the dark theme when tabs are disabled. Oct 24, 2021
@zadjii-msft
Copy link
Member

.... I could have swore we were already calling the API that let us do that. Why doesn't that work anymore? Hmm. Thanks for pointing this out!

@zadjii-msft zadjii-msft added Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Oct 25, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Oct 25, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 29, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Dec 5, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 5, 2022
@zadjii-msft zadjii-msft mentioned this issue Dec 12, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Dec 12, 2022
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Jan 12, 2023
@ghost ghost closed this as completed in #14536 Jan 19, 2023
ghost pushed a commit that referenced this issue Jan 19, 2023
@zadjii-msft
Use a dark titlebar when we've requested dark theme (#14536)
79eb9b3 
This applies to `"showTabsInTitlebar": false,`. We literally never set that for the `IslandWindow` before, only ever the NCIW. 

Closes #11589


![update-titlebar-for-theme](https://user-images.githubusercontent.com/18356694/207109370-a63a8b19-4c42-4b1f-8d39-8c3abdf1b403.gif)


For a dramatic example - here's the IW with mica enabled, in dark mode:

![image](https://user-images.githubusercontent.com/18356694/207109465-a6165637-31a5-45a4-bff0-51ac79404cd6.png)

Theme json:

```json
        {
            "name": "chonk",
            "tab":
            {
                "background": "#00000000",
                "unfocusedBackground": "#00000000",
                "showCloseButton": "never"
            },
            "tabRow":
            {
                "background": "#00000000",
                "unfocusedBackground": "#00000000",
            },
            "window":
            {
                "applicationTheme": "dark",
                "useMica": true
            }
        },
```
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 19, 2023
@RokeJulianLockhart RokeJulianLockhart changed the title Please do cause the title-bar to use the dark theme when tabs are disabled. Cause the title-bar to use the dark theme when tabs are disabled. Jan 20, 2023
@ghost
Copy link

ghost commented Jan 24, 2023

🎉This issue was addressed in #14536, which has now been successfully released as Windows Terminal Preview v1.17.1023.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Use a dark titlebar when we've requested dark theme microsoft/terminal
3 participants
@DHowett @zadjii-msft @RokeJulianLockhart