-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context menu on tabs doesn't close when clicking in the title bar #7988
Comments
Coming only from higher-level UI toolkits in managed code I always thought the popup was somewhat responsible for closing itself by getting mouse capture and reacting to clicks elsewhere and closing itself. But perhaps that's the more complicated or otherwise undesirable option in native Win32. No actual idea, though :) |
You're totally right, @jroessel! We're in the unfortunate position of using two different UI frameworks at the same time (XAML and Win32). To get our titlebar draggable while still being able to theme it like the rest of the application, we had to eat mouse clicks in a region at the top of the window. Doing that obscures the click target that would dismiss the flyout menu 😄 |
Close the tab context menu when clicking on the title bar ## Detailed Description of the Pull Request / Additional comments Following #2438, hide the tabs context menu on `TerminalPage::TitlebarClicked()`. We don't know which of the tabs is showing the context menu, do it on all tabs. ## Validation Steps Performed Open the context menu from any tab, click on title bar and see the context menu disappear. Closes #7988
Close the tab context menu when clicking on the title bar ## Detailed Description of the Pull Request / Additional comments Following #2438, hide the tabs context menu on `TerminalPage::TitlebarClicked()`. We don't know which of the tabs is showing the context menu, do it on all tabs. ## Validation Steps Performed Open the context menu from any tab, click on title bar and see the context menu disappear. Closes #7988 (cherry picked from commit 7e86001)
🎉This issue was addressed in #8010, which has now been successfully released as Handy links: |
🎉This issue was addressed in #8010, which has now been successfully released as Handy links: |
Environment
Steps to reproduce
Expected behavior
The context menu closes, regardless of where the click in step 2 goes.
Actual behavior
The context menu closes in pretty much all places, even different applications (presumably because losing focus also closes it), but doesn't close when clicking the title bar of WIndows Terminal. It does close when clicking controls in the title bar, though, even the default window buttons in the upper right.
The text was updated successfully, but these errors were encountered: