Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyout/Dropdown light dismiss not working with Titlebar click #2028

Closed
mdtauk opened this issue Jul 19, 2019 · 3 comments · Fixed by #2438
Closed

Flyout/Dropdown light dismiss not working with Titlebar click #2028

mdtauk opened this issue Jul 19, 2019 · 3 comments · Fixed by #2438
Assignees
@zadjii-msft
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal 1908.1

Comments

@mdtauk
Copy link

mdtauk commented Jul 19, 2019

Environment

Windows build number: 18362.263
Windows Terminal version (if applicable):0.0.1.0 - Built 01:02 Fri 19 July

Steps to reproduce

When you tap on the drop down button, and bring the flyout on screen. Clicking on the Titlebar will not trigger the light dismiss behaviour and the flyout remains open. Tapping on the terminal display, tab or tab bar, works as expected.

Expected behavior

Tapping on the titlebar should dismiss the flyout
image

Actual behavior

Tapping the Titlebar does not dismiss it, and if you drag the window, the flyout lags in moving to the correct position

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 19, 2019
@DHowett-MSFT
Copy link
Contributor

Alas, these are both real issues and you're going to tell me to file them on the WinUI 3.0 team and I'm going to tell you that we report to the same manager, so I'll just comment all that right now and leave this open/marked.

@DHowett-MSFT DHowett-MSFT added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 20, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 20, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Jul 20, 2019
@DHowett-MSFT DHowett-MSFT changed the title Bug Report Flyout/Dropdown light dismiss not working with Titlebar click Flyout/Dropdown light dismiss not working with Titlebar click Jul 20, 2019
@mdtauk
Copy link
Author

mdtauk commented Jul 20, 2019

Sorry @DHowett-MSFT :)

@DHowett-MSFT DHowett-MSFT mentioned this issue Aug 5, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Aug 5, 2019
Closed
29 tasks
@zadjii-msft zadjii-msft mentioned this issue Aug 8, 2019
Closed
29 tasks
@zadjii-msft zadjii-msft self-assigned this Aug 14, 2019
zadjii-msft added a commit that referenced this issue Aug 15, 2019
@zadjii-msft
When the titlebar is clicked, dismiss the new tab flyout
29e0c5d 
  Fixes #2028.
zadjii-msft added a commit that referenced this issue Aug 15, 2019
@zadjii-msft
When the titlebar is clicked, dismiss the new tab flyout
2fc6cd4 
  Fixes #2028.
@zadjii-msft zadjii-msft mentioned this issue Aug 15, 2019
Merged
1 task
@ghost ghost added the In-PR This issue has a related PR label Aug 15, 2019
@ghost ghost closed this as completed in #2438 Aug 16, 2019
ghost pushed a commit that referenced this issue Aug 16, 2019
@zadjii-msft
When the titlebar is clicked, dismiss the new tab flyout (#2438)
24ea086 
* When the titlebar is clicked, dismiss the new tab flyout

  Fixes #2028.

* Fix this for the base IslandWindow as well
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 16, 2019
@ghost
Copy link

ghost commented Aug 27, 2019

🎉This issue was addressed in #2438, which has now been successfully released as Windows Terminal Preview v0.4.2382.0.:tada:

Handy links:

@zadjii-msft zadjii-msft mentioned this issue Sep 19, 2019
Closed
@zadjii-msft zadjii-msft mentioned this issue Oct 2, 2019
Merged
This was referenced May 11, 2020
Closed
Closed
@zadjii-msft zadjii-msft mentioned this issue Oct 21, 2020
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal 1908.1
Development

Successfully merging a pull request may close this issue.

When the titlebar is clicked, dismiss the new tab flyout microsoft/terminal
3 participants
@mdtauk @DHowett-MSFT @zadjii-msft