-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neovim theme background colors are being stripped when scrolling #70
Comments
From @rodrymbo on November 30, 2017 17:47 You could fire up sshd and log in to it with PuTTY or similar and see if the same background problem continues. If it works okay in a terminal but not in the console, then this is a console issue... Work continues to make the console work more and more like a terminal... |
From @zadjii-msft on November 30, 2017 19:12 @jasin What windows build# are you on? There was a bit of churn in that area recently. I think I already fixed that, but if not, knowing the specific build number will help me track it down. |
From @jasin on December 1, 2017 11:18 @zadjii-msft Windows Version 10.0.16299 Build 16299 |
From @zadjii-msft on December 1, 2017 17:16 @jasin could you post what the following python script looks like when you run it in the console? import sys
import time
def csi(seq):
sys.stdout.write('\x1b[{}'.format(seq))
def write(s):
sys.stdout.write(s)
if __name__ == '__main__':
print('Clearing the line paints to the end?')
print('\E[42mfoo\E[43m\E[KTest')
csi('42m')
write('foo')
csi('43m')
csi('K')
write('Test')
csi('m')
print('')
print('\E[42mfoo\E[43m\E[K\\nTest')
csi('42m')
write('foo')
csi('43m')
csi('K')
write('\nTest')
csi('m')
print('')
print('\E[42mfoo\E[43m\E[1KTest')
csi('42m')
write('foo')
csi('43m')
csi('1K')
write('Test')
csi('m')
print('')
print('\E[42mfoo\E[43m\E[1K\\nTest')
csi('42m')
write('foo')
csi('43m')
csi('1K')
write('\nTest')
csi('m')
print('')
print('\E[42mfoo\E[43m\E[2KTest')
csi('42m')
write('foo')
csi('43m')
csi('2K')
write('Test')
csi('m')
print('')
print('\E[42mfoo\E[43m\E[2K\\nTest')
csi('42m')
write('foo')
csi('43m')
csi('2K')
write('\nTest')
csi('m')
print('')
print("\x1b[48;2;64;128;255mX\x1b[48;2;128;128;255m\x1b[KX")
csi('m')
print('') You can just paste that into a file like |
From @jasin on December 1, 2017 19:0 Hope this helps |
From @zadjii-msft on December 1, 2017 19:7 Welp, that's exactly how that's supposed to look. Shoot. This must be some other weirdness then. Just to help investigate, are there any specific plugins you have installed? Have you modified your neovim configuration at all? (I'm not really familiar with neovim, but for normal vim I'm talking about the .vimrc file) I'll file a bug on my end to make sure this gets tracked down. |
From @jasin on December 1, 2017 20:10 Well I am not sure I fully understand the problem so it seems. I was using neovim during an ssh session to my FreeBSD box. That is where I do my development. I decided to quickly install the neovim package from the unstable ppa and I do not see the issue locally that I am experiencing during an ssh session to my FreeBSD box. I do run zsh shell on that server box. To note, I did run the py scrypt on my FreeBSD box through ssh session and you said that looked ok, so this must specifically be a neovim/FreeBSD issue over SSH. But that is as far as I am willing to comment. I'm not sure I know enough to look into it further without some possible clues. |
From @jasin on December 1, 2017 20:39 Further investigation shows this is not just limited to neovim, I see the issue in vim as well over SSH to FreeBSD, but slightly different, opening up a file now shows me this without even having to scroll. I have also ruled out the shell, makes no difference, didn't think it would, but I double checked using bash shell |
From @zadjii-msft on December 1, 2017 20:43 @jasin can you post the output of |
From @jasin on December 1, 2017 20:57 Here you go
|
From @msundin on December 27, 2017 19:31 I can confirm this bug in Ubuntu 16.04 after Fall Creators update and via SSH to FreeNAS (FreeBSD). When scrolling, the background color (in this case grey) disappears where there is no text. Both in Vim and Neovim. This makes it impossible to use sophisticated color schemes in Vim/Neovim: |
From @zadjii-msft on January 4, 2018 22:17 Okay yea I'm seeing this again. To limit the repro variables for myself:
|
From @sus007 on January 5, 2018 11:18 I too confirm this bug in my system:
|
From @zadjii-msft on January 11, 2018 22:51 I got this figured out. I was off-by-one on copying the RGB attributes of the last run of characters. gnome-terminal (for reference): I'm gonna add some tests and get this code reviewed. Thanks for all the persistence and patience folks! |
|
As a temporary workaround, setting |
Happily I found this bug listing. It seems to be an xterm default rendering issue. I added the following to my .bashrc:
The result is vim properly renders background colours all the way to the end. Using default xterm-256color I get the results of the gif above. Interesting note: This seems to be related to new line characters. Using delete/backspace on a line and causing the text to shift left (specifically left) caused the background to render all the way to the right again on that line specifically. |
I'll add it to my backlog and come back and investigate. I thought I fixed this for Spring Creator's Update, but I don't really know when that's actually getting released.... |
It may well have been resolved in the spring update, I'm not running a
preview build. Here's hoping for a quick test cycle though.
…On Fri, Apr 20, 2018, 13:02 Mike Griese, ***@***.***> wrote:
I'll add it to my backlog and come back and investigate. I thought I fixed
this for Spring Creator's Update, but I don't really know when that's
actually getting released....
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABNRVnitb6foR4VEkQcpII2oE94Qo5X7ks5tqhSTgaJpZM4SHvdT>
.
|
it would be nice if there was some indication of when this is supposed to be fixed?!?!? I am running the latest Spring creators update 1709 16299.402 I am still seeing the issue, but I have no idea what has been updated. All I seem to get is cumulative security updates. This is starting to get really frustrating. A fix should not be this hard to push out. setting screen-256color does nothing for nvim, it just mangles the rendering worse than before. |
@jasin For the record, 16299 is still Fall Creator's Update. "Spring Creator's Update" (which is I guess just "April Update" now, don't ask me I'm not in marketing) should have a build number that's something like "17134" or greater. This issue has kinda evolved from one manifestation of the bug to the next similar, yet different incarnation. When I get to it, I'll let you know. |
I can't seem to get this to repro anymore, in any fashion. If someone can get me a repro (color scheme/.vimrc) that this still repros on Insider's with, I'll be happy to re-open, but I think it's fixed now. |
I suppose you can't repro completely because I'm not using Ubuntu on WSL (which would be normal). But here is the screenshot of the bug.
Here my .vimrc (which is basically the default one) and the colorscheme (base16) |
To reproduce the above, install vim-gtk on Debian (latest windows stable), then try installing the summerfruit256 colorscheme |
In standard Vim, putting this into the vimrc did the trick:
|
Thanks @ndrewxie! This makes it seem like a tmux (tmux/tmux#109) and screen[1] issue moreso than a conhost issue. [1] from
|
I can reproduce this with a minimal vim: Where jellybeans is this specific version. (Also occurs with zellner, xoria256, sandydune, etc. but couldn't repro with any colors shipped with vim7. Probably because vim7 doesn't ship with schemes using 256 colors.) I'm on Windows 1909 (OS Build 18363.657). (Public version, not insider.) Using WSL: Ubuntu 14.04.5 LTS VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Nov 24 2016 16:43:18) &term == xterm-256color Running a terminal as bash.exe ("Microsoft Bash Launcher") Strangely, I only noticed this recently. Maybe after my Windows Update on Friday? Either of these lines will make the problem go away, but at the cost of reduced colours: set term=xterm
set t_Co=16 I'm using the bash.exe that came with installing WSL through the Windows Store (2 years ago). I'm not using "Windows Terminal (Preview)" from the Windows Store (testing that, the issue doesn't occur because &term is win32 and &t_Co is 16 -- so it doesn't support 256 colours). The WSL repo asks to report issues here, so I assume my experience is relevant to this bug? |
This would be a great issue for @Kayla Cinnamon<mailto:[email protected]> & team to explore. Thanks for filing David.
Rich.
|
@idbrii since this issue is closed and you seem to be having some slightly different symptoms, would you mind filling a new one so that we might track it appropriately? Thanks. |
From @jasin on November 30, 2017 15:25
This is a similar problem to the one listed here, but since someone decided to lock that thread I'll start my own.
#1706
@zadjii-msft
Simply put, I am running ubuntu from the windows store
lsb_release -a returns 16.04.3 LTS
You can see the problem in neovim, when the file is scrolled down the background color is stripped. I have no idea if this problem has been fixed in 16.04.3 LTS or if this is only fixed in the insider version?? Any sort of tips on how I can further look into the problem I'd happy to look into it and report back.
Copied from original issue: microsoft/WSL#2710
The text was updated successfully, but these errors were encountered: