Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect background color when scrolling up #129

Closed
j4james opened this issue Mar 8, 2018 · 2 comments
Closed

Incorrect background color when scrolling up #129

j4james opened this issue Mar 8, 2018 · 2 comments
Assignees
Labels
Product-Conhost For issues in the Console codebase Work-Item It's being tracked by an actual work item internally. (to be removed soon)
Milestone

Comments

@j4james
Copy link
Collaborator

j4james commented Mar 8, 2018

Windows build number: [Version 10.0.16299.248]

If I use an ANSI sequence to set the background color attribute, then move to the bottom of the screen and output some newlines so the screen scrolls up, I'd expect the newly revealed lines to have the background color that I just set.

Similarly, if I move to the top of the screen, and output the reverse feed sequence (\033M) so the screen scrolls down, I'd again expect the new revealed lines to use the current background color.

The later case (scrolling down) works as expected, but scrolling up does not.

Test case (from a bash shell):
printf "\033[44m\033[200B\n\n\033[200A\033M\033[m"

I'd expect the above sequence to result in both the top and bottom lines of the screen having a blue background (which is what I see in a Linux console), but in the Windows 10 console, only the top line is blue.

Note that the scroll up sequence (\033[S) has similar problems, although it's a little more complicated. The first line that's revealed when scrolling up will have the wrong background color, but subsequent lines will be correct. Scrolling down (like reverse feed) always seems to work as expected.

I suspect this may be related to issue #70. I apologise if it's just a duplicate.

@bitcrazed bitcrazed assigned bitcrazed and zadjii-msft and unassigned bitcrazed May 4, 2018
@bitcrazed bitcrazed added this to the RS5 milestone May 4, 2018
@bitcrazed bitcrazed added Product-WSL Issue that should probably go to Microsoft/WSL console labels May 4, 2018
@bitcrazed
Copy link
Contributor

Thanks for filing. I can confirm that Console with Ubuntu/WSL does this:
image

Whereas an Ubuntu VM does this:
image

@zadjii-msft zadjii-msft added Work-Item It's being tracked by an actual work item internally. (to be removed soon) and removed Product-WSL Issue that should probably go to Microsoft/WSL labels May 7, 2018
@zadjii-msft zadjii-msft added Product-Conhost For issues in the Console codebase and removed console labels May 21, 2018
@zadjii-msft
Copy link
Member

I love when bug reports have a nice simple string of VT sequences like this. Makes it really easy to debug and find solutions.

Submitting the PR now, shouldn't be too hard to get through code review.

@zadjii-msft zadjii-msft added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Work-Item It's being tracked by an actual work item internally. (to be removed soon) labels Jul 19, 2018
@zadjii-msft zadjii-msft added Work-Item It's being tracked by an actual work item internally. (to be removed soon) and removed Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. labels Jul 30, 2018
@zadjii-msft zadjii-msft modified the milestones: RS5, 19H1 Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Conhost For issues in the Console codebase Work-Item It's being tracked by an actual work item internally. (to be removed soon)
Projects
None yet
Development

No branches or pull requests

3 participants