-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It is not possible to scroll tabs list without touch screen #444
Comments
I think the tabs should resize to a particular min-width, and then start scrolling. Basically, the tab behaviour should be like Firefox and not Chrome. |
So there's a LOT of different opinions about how tabs should be sized. I'm not even going to open that can of worms here. What I can say is that mouse scrolling of the tabs _should_work. Unfortunately, we're using a pretty early build of the TabControl, so when you try scrolling it with the mouse, the parts of the tabs that weren't visible before don't actually render for some reason. If you manually resize the window, then the tabs will figure themselves out. |
I can confirm that scrolling the tab list with does not seem to work at all for me either. I don't have a touch screen to test. Windows build 10.0.18362.86 |
Scrolling works with a mouse but not as intended. When I open many terminal tabs as can be seen in the screenshot below, it doesn't show the complete tab and when I open more tabs, they don't even appear in the bar. (the maximum number of tabs are 4) |
Ah, I was using my surfaces trackpad |
@kumarharsh commented on May 6, 2019, 11:53 PM EDT:
@zadjii-msft commented on May 7, 2019, 12:56 PM EDT:
Might be better suited as a separate issue, but since it came up in here, what about a setting for minimum tab width instead of forcing either "scrolling after min-width" or "no min-width, no scroll" tabs: |
@Californ1a yeah, that sounds like a good solution. |
@Californ1a Let's open a separate issue for discussion of tab sizing. I'd rather each issue discussed an atomic topic, in this case, scrolling the tabs without a touchscreen. |
I rebuilt it and deployed it again and it works 😉 |
* We had to move to the final API: * Items -> TabItems * Items.VectorChanged -> TabItemsChanged * TabClose -> TabCloseRequested * TabViewItem.Icon -> TabViewItem.IconSource * TabRowControl has been converted to a ContentPresenter, which simplifies its logic a little bit. * TerminalPage now differentiates MUX and WUX a little better * Because of the change from Icon to IconSource in TabViewItem, Utils::GetColoredIcon needed to be augmented to support MUX IconSources. It was still necessary to use for WUX, so it's been templatized. * I moved us from WUX SplitButton to MUX SplitButton and brought the style in line with the one typically provided by TabView. * Some of our local controls have had their backgrounds removed so they're more amenable to being placed on other surfaces. * I'm suppressing the TabView's padding. * I removed a number of apparently dead methods from App. * I've simplified the dragbar's sizing logic and eventing. * The winmd harvester needed to be taught to not try to copy winmds for framework packages. * We now only initialize the terminal once we know the size Closes #1896. Closes #444. Closes #857. Closes #771. Closes #760.
🎉This issue was addressed in #3027, which has now been successfully released as Handy links: |
Your Windows build number: 10.0.18890.1000
What you're doing and what's happening: If you open enough tabs you are unable to see all tabs at once. The only way to solve this is to either close this or use a touch screen to scroll horizontally.
What's wrong / what should be happening instead: It should be possible to scroll tabs without a touch screen or the tabs should automatically resize so they all fit at once.
The text was updated successfully, but these errors were encountered: